All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] PXE support for grub2
Date: Sat, 2 Aug 2008 13:49:59 +0200	[thread overview]
Message-ID: <20080802114959.GA16063@thorin> (raw)
In-Reply-To: <ca0f59980808020420q7ec26c69t8f1523f2d507c7b1@mail.gmail.com>

On Sat, Aug 02, 2008 at 07:20:31PM +0800, Bean wrote:
> >> --- a/kern/i386/pc/startup.S
> >> +++ b/kern/i386/pc/startup.S
> >> @@ -2053,3 +2053,102 @@ FUNCTION(grub_vbe_bios_set_palette_data)
> >>       popl    %ebx
> >>       popl    %ebp
> >>       ret
> >> +
> >> +
> >> +pxe_rm_entry:
> >> +     .long   0
> >> +
> >> +/*
> >> + * struct grub_pxenv *grub_pxe_scan (void);
> >> + */
> >> +FUNCTION(grub_pxe_scan)
> >
> > Could these go in a module?  If they're only used by disk/i386/pc/pxe.c,
> > maybe they could be merged with that?
> 
> The problem is that they need to call real mode function provided by
> the pxe rom, so this code must be loaded under 1m. We can solve this
> with real mode stub or the patch suggested by daChaac, but it's not
> there yet. So we need to keep it in startup.S for some time.

Well I guess we can live with that for a while...

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."



  reply	other threads:[~2008-08-02 11:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-30 16:50 [PATCH] PXE support for grub2 Bean
2008-08-01  3:46 ` Bean
2008-08-01  3:52   ` Pavel Roskin
2008-08-01 11:32     ` Robert Millan
2008-08-01 16:21       ` Pavel Roskin
2008-08-01 16:59         ` Bean
2008-08-02  4:34           ` Bean
2008-08-02 10:48 ` Robert Millan
2008-08-02 11:20   ` Bean
2008-08-02 11:49     ` Robert Millan [this message]
2008-08-04 21:08 ` Marco Gerards
2008-08-05  3:36   ` Bean
2008-08-05  8:16     ` Marco Gerards
2008-08-05 15:15       ` Bean
2008-08-06  6:18         ` Bean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080802114959.GA16063@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.