From: Gleb Natapov <gleb@qumranet.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3]: Add -uuid option to Qemu
Date: Tue, 5 Aug 2008 16:53:19 +0300 [thread overview]
Message-ID: <20080805135319.GB3689@minantech.com> (raw)
In-Reply-To: <4898590B.50300@redhat.com>
On Tue, Aug 05, 2008 at 03:43:39PM +0200, Gerd Hoffmann wrote:
> Chris Lalancette wrote:
> > As suggested by Anthony, this patch and the next one were split apart. This
> > patch just adds the basic plumbing to qemu to be able to set the uuid on the
> > command-line, and retrieve the information via "info uuid".
>
> What is the point of CONFIG_UUID and the libuuid test in that patch?
> I can't see any dependency on it in the source code. IMHO the -uuid
> switch should be present unconditionally.
Here is the patch series where there is no CONFIG_UUID test (was posted
here two month ago):
http://lists.gnu.org/archive/html/qemu-devel/2008-06/msg00443.html
http://lists.gnu.org/archive/html/qemu-devel/2008-06/msg00444.html
And this one checks for libuuid and uses it for random uuid generation if
available (UUID should be RFC compliant):
http://lists.gnu.org/archive/html/qemu-devel/2008-06/msg00446.html
--
Gleb.
next prev parent reply other threads:[~2008-08-05 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 13:25 [Qemu-devel] [PATCH 2/3]: Add -uuid option to Qemu Chris Lalancette
2008-08-05 13:43 ` Gerd Hoffmann
2008-08-05 13:53 ` Gleb Natapov [this message]
2008-08-05 14:36 ` Andreas Färber
2008-08-05 13:53 ` Chris Lalancette
2008-08-05 14:32 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080805135319.GB3689@minantech.com \
--to=gleb@qumranet.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.