All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean MacLennan <smaclennan@pikatech.com>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "Karsten Keil" <kkeil@suse.de>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Andreas.Eversberg" <Andreas.Eversberg@versatel.de>,
	<isdn4linux@listserv.isdn4linux.de>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] Fix remaining big endian issue of hfcmulti
Date: Tue, 5 Aug 2008 17:59:37 -0400	[thread overview]
Message-ID: <20080805175937.49a5ba32@lappy.seanm.ca> (raw)
In-Reply-To: <alpine.LFD.1.10.0808051435260.3257@nehalem.linux-foundation.org>

On Tue, 5 Aug 2008 14:37:19 -0700 (PDT)
"Linus Torvalds" <torvalds@linux-foundation.org> wrote:

> On Tue, 5 Aug 2008, Sean MacLennan wrote:
> > 
> > Why not select PIO or MMIO at config time?  
> 
> Umm. Then you can't run a generic driver that can do either. That's
> the worst choice of all.

But do we really need a generic driver that can do either? Maybe for the
current mISDN driver, but when you get to other chip ports, say the
xhfc, you have to select the low level interface at compile time. Or I
should say you currently have to select at config time.

I'm not arguing that we *have* to do it this way. I just don't think we
should throw out the simplest method without some thought. There is
some precedence for a config time option, for example the 8139too
ethernet driver.

Cheers,
   Sean

  reply	other threads:[~2008-08-05 22:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-02 14:35 [PATCH 3/4] Fix remaining big endian issue of hfcmulti Karsten Keil
2008-08-04 12:03 ` David Woodhouse
2008-08-04 14:29   ` Karsten Keil
2008-08-05  4:29 ` Benjamin Herrenschmidt
2008-08-05 11:31   ` Karsten Keil
2008-08-05 13:04     ` Benjamin Herrenschmidt
2008-08-05 17:25       ` Karsten Keil
2008-08-05 18:42         ` Linus Torvalds
2008-08-05 21:02           ` Karsten Keil
2008-08-05 21:23             ` Sean MacLennan
2008-08-05 21:37               ` Linus Torvalds
2008-08-05 21:59                 ` Sean MacLennan [this message]
2008-08-05 23:04                   ` Benjamin Herrenschmidt
2008-08-05 23:38                     ` Sean MacLennan
2008-08-06  0:18                   ` Karsten Keil
2008-08-06  0:33                     ` Benjamin Herrenschmidt
2008-08-05 21:46               ` Benjamin Herrenschmidt
2008-08-05 21:45             ` Benjamin Herrenschmidt
2008-08-05 21:43         ` Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2008-08-07 11:01 AW: " Andreas.Eversberg
2008-08-07 13:46 ` Karsten Keil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080805175937.49a5ba32@lappy.seanm.ca \
    --to=smaclennan@pikatech.com \
    --cc=Andreas.Eversberg@versatel.de \
    --cc=benh@kernel.crashing.org \
    --cc=isdn4linux@listserv.isdn4linux.de \
    --cc=kkeil@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.