From: Linus Torvalds <torvalds@linux-foundation.org>
To: Sean MacLennan <smaclennan@pikatech.com>
Cc: Karsten Keil <kkeil@suse.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"Andreas.Eversberg" <Andreas.Eversberg@versatel.de>,
isdn4linux@listserv.isdn4linux.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] Fix remaining big endian issue of hfcmulti
Date: Tue, 5 Aug 2008 14:37:19 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0808051435260.3257@nehalem.linux-foundation.org> (raw)
In-Reply-To: <20080805172324.45853d98@lappy.seanm.ca>
On Tue, 5 Aug 2008, Sean MacLennan wrote:
>
> Why not select PIO or MMIO at config time?
Umm. Then you can't run a generic driver that can do either. That's the
worst choice of all.
As to where in the stack to do the choice - I suspect it's easier if it's
done at the lowest level, but that can cause performance issues (ie
testing that flag over and over again). The mmio code avoids some of the
performance issues exactly by doing the "repeat" versions - so for some
cases you can do the check once at the top, and then just repeat.
Linus
next prev parent reply other threads:[~2008-08-05 21:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-02 14:35 [PATCH 3/4] Fix remaining big endian issue of hfcmulti Karsten Keil
2008-08-04 12:03 ` David Woodhouse
2008-08-04 14:29 ` Karsten Keil
2008-08-05 4:29 ` Benjamin Herrenschmidt
2008-08-05 11:31 ` Karsten Keil
2008-08-05 13:04 ` Benjamin Herrenschmidt
2008-08-05 17:25 ` Karsten Keil
2008-08-05 18:42 ` Linus Torvalds
2008-08-05 21:02 ` Karsten Keil
2008-08-05 21:23 ` Sean MacLennan
2008-08-05 21:37 ` Linus Torvalds [this message]
2008-08-05 21:59 ` Sean MacLennan
2008-08-05 23:04 ` Benjamin Herrenschmidt
2008-08-05 23:38 ` Sean MacLennan
2008-08-06 0:18 ` Karsten Keil
2008-08-06 0:33 ` Benjamin Herrenschmidt
2008-08-05 21:46 ` Benjamin Herrenschmidt
2008-08-05 21:45 ` Benjamin Herrenschmidt
2008-08-05 21:43 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2008-08-07 11:01 AW: " Andreas.Eversberg
2008-08-07 13:46 ` Karsten Keil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0808051435260.3257@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=Andreas.Eversberg@versatel.de \
--cc=benh@kernel.crashing.org \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=smaclennan@pikatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.