From: Joel Becker <Joel.Becker@oracle.com>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: mfasheh@suse.com, ocfs2-devel@oss.oracle.com,
linux-kernel@vger.kernel.org
Subject: [Ocfs2-devel] [PATCH] ocfs2/cluster/netdebug.c: fix warning
Date: Tue, 5 Aug 2008 16:22:55 -0700 [thread overview]
Message-ID: <20080805232254.GO22600@mail.oracle.com> (raw)
In-Reply-To: <20080805205041.GD17320@orion>
On Wed, Aug 06, 2008 at 12:50:41AM +0400, Alexander Beregalov wrote:
> On Tue, Aug 05, 2008 at 01:29:48PM -0700, Joel Becker wrote:
> > suseconds_t is a signed long. Can you change the format to %ld
> > and cast to long? Unfortunately, we need the cast, as sparc64 and
> > parisc treat it as int.
>
> Then we should change cast from unsigned long to long for every tv_usec, right?
Yup.
Joel
--
"You can get more with a kind word and a gun than you can with
a kind word alone."
- Al Capone
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <Joel.Becker@oracle.com>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: mfasheh@suse.com, ocfs2-devel@oss.oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ocfs2/cluster/netdebug.c: fix warning
Date: Tue, 5 Aug 2008 16:22:55 -0700 [thread overview]
Message-ID: <20080805232254.GO22600@mail.oracle.com> (raw)
In-Reply-To: <20080805205041.GD17320@orion>
On Wed, Aug 06, 2008 at 12:50:41AM +0400, Alexander Beregalov wrote:
> On Tue, Aug 05, 2008 at 01:29:48PM -0700, Joel Becker wrote:
> > suseconds_t is a signed long. Can you change the format to %ld
> > and cast to long? Unfortunately, we need the cast, as sparc64 and
> > parisc treat it as int.
>
> Then we should change cast from unsigned long to long for every tv_usec, right?
Yup.
Joel
--
"You can get more with a kind word and a gun than you can with
a kind word alone."
- Al Capone
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-08-05 23:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 20:10 [PATCH] ocfs2/cluster/netdebug.c: fix warning Alexander Beregalov
2008-08-05 20:12 ` [Ocfs2-devel] " Alexander Beregalov
2008-08-05 20:29 ` Joel Becker
2008-08-05 20:29 ` Joel Becker
2008-08-05 20:50 ` Alexander Beregalov
2008-08-05 20:51 ` [Ocfs2-devel] " Alexander Beregalov
2008-08-05 23:22 ` Joel Becker [this message]
2008-08-05 23:22 ` Joel Becker
2008-08-06 21:24 ` [Ocfs2-devel] " Mark Fasheh
2008-08-06 21:24 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080805232254.GO22600@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=a.beregalov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.