Re: [PATCH] Home-End keys in menu

[Carles Pina i Estany <carles@pina.cat>]

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]



Hello,

On Aug/05/2008, Marco Gerards wrote:

> > Some weeks ago I sent a patch that didn't have any discussion. I'm
> > sending it again, maybe everybody was in holidays :-)
> >
> > Actually I updated the patch (added some spaces to comply with the
> > coding style).
> >
> > * menu/normal.c: Add Home and End keys in grub-menu
> 
> The first line of the changelog entry is missing (name + e-mail
> address).  Please mention the function you change like:

done! (see below)

[...]

> The indentation of the case statement doesn't seem right...

[...]

> This indentation also looks funny...

was not right (not a problem, it's fixed now).

Also, the indentation got worst in the mail :-)

Changelog:
-------
2008-08-06  Carles Pina i Estany  <carles@pina.cat>

	* menu/normal.c (run_menu): Add Home and End keys in grub-menu.
-------

Patch is attached.

Thank you,

-- 
Carles Pina i Estany		GPG id: 0x17756391
	http://pinux.info

[-- Attachment #2: home_end3.patch --]
[-- Type: text/x-diff, Size: 654 bytes --]

Index: normal/menu.c
===================================================================
--- normal/menu.c	(revision 1786)
+++ normal/menu.c	(working copy)
@@ -405,6 +405,22 @@
 	  
 	  switch (c)
 	    {
+	    case GRUB_TERM_HOME:
+	      first = 0;
+	      offset = 0;
+	      print_entries (menu, first, offset);
+	      break;
+
+	    case GRUB_TERM_END:
+	      offset = menu->size - 1;
+	      if (offset > GRUB_TERM_NUM_ENTRIES - 1)
+		{
+		  first = offset - (GRUB_TERM_NUM_ENTRIES - 1);
+		  offset = GRUB_TERM_NUM_ENTRIES - 1;
+		}
+		print_entries (menu, first, offset);
+	      break;
+
 	    case 16:
 	    case '^':
 	      if (offset > 0)