Re: [PATCH] Home-End keys in menu

[Marco Gerards <mgerards@xs4all.nl>]

Hi,

Carles Pina i Estany <carles@pina.cat> writes:

> Some weeks ago I sent a patch that didn't have any discussion. I'm
> sending it again, maybe everybody was in holidays :-)
>
> Actually I updated the patch (added some spaces to comply with the
> coding style).
>
> * menu/normal.c: Add Home and End keys in grub-menu

The first line of the changelog entry is missing (name + e-mail
address).  Please mention the function you change like:

 * menu/normal.c (foo): Blah blah.

And end a sentence with a "."

>> Index: normal/menu.c
>> ===================================================================
>> --- normal/menu.c	(revision 1718)
>> +++ normal/menu.c	(working copy)
>> @@ -405,6 +405,22 @@
>>  	  
>>  	  switch (c)
>>  	    {
>> +            case GRUB_TERM_HOME:
>> +	       first=0;
>> +	       offset=0;
>> +	       print_entries (menu, first, offset);
>> +	       break;

The indentation of the case statement doesn't seem right...

>> +	    case GRUB_TERM_END:
>> +	      offset = menu->size - 1;
>> +	      if (offset > GRUB_TERM_NUM_ENTRIES - 1)
>> +		{
>> +                  first = offset - (GRUB_TERM_NUM_ENTRIES - 1);
>> +		  offset = GRUB_TERM_NUM_ENTRIES - 1;

This indentation also looks funny...

>> +		}
>> +		print_entries (menu, first, offset);
>> +	      break;
>> +
>>  	    case 16:
>>  	    case '^':
>>  	      if (offset > 0)
>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>
> -- 
> Carles Pina i Estany		GPG id: 0x17756391
> 	http://pinux.info
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel