* [PATCH] usb: cdc-acm: flags passed to spin_lock_irqsave must be unsigned
@ 2008-08-03 16:50 Marcin Slusarz
2008-08-07 0:05 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Slusarz @ 2008-08-03 16:50 UTC (permalink / raw)
To: LKML; +Cc: Oliver Neukum, Greg Kroah-Hartman
gcc warned about it:
drivers/usb/class/cdc-acm.c: In function 'acm_waker':
drivers/usb/class/cdc-acm.c:527: warning: comparison of distinct pointer types lacks a cast
drivers/usb/class/cdc-acm.c:529: warning: comparison of distinct pointer types lacks a cast
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Oliver Neukum <oliver@neukum.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/usb/class/cdc-acm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 0725b18..a92395b 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -512,7 +512,7 @@ static void acm_softint(struct work_struct *work)
static void acm_waker(struct work_struct *waker)
{
struct acm *acm = container_of(waker, struct acm, waker);
- long flags;
+ unsigned long flags;
int rv;
rv = usb_autopm_get_interface(acm->control);
--
1.5.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: cdc-acm: flags passed to spin_lock_irqsave must be unsigned
2008-08-03 16:50 [PATCH] usb: cdc-acm: flags passed to spin_lock_irqsave must be unsigned Marcin Slusarz
@ 2008-08-07 0:05 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2008-08-07 0:05 UTC (permalink / raw)
To: Marcin Slusarz; +Cc: LKML, Oliver Neukum, Greg Kroah-Hartman
On Sun, Aug 03, 2008 at 06:50:14PM +0200, Marcin Slusarz wrote:
> gcc warned about it:
> drivers/usb/class/cdc-acm.c: In function 'acm_waker':
> drivers/usb/class/cdc-acm.c:527: warning: comparison of distinct pointer types lacks a cast
> drivers/usb/class/cdc-acm.c:529: warning: comparison of distinct pointer types lacks a cast
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Oliver Neukum <oliver@neukum.org>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
Just got this fix from someone else first, sorry, but thanks for the
patch.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-07 2:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-03 16:50 [PATCH] usb: cdc-acm: flags passed to spin_lock_irqsave must be unsigned Marcin Slusarz
2008-08-07 0:05 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.