All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Gavrilov <angavrilov@gmail.com>
To: Christian Jaeger <christian@jaeger.mine.nu>
Cc: git@vger.kernel.org
Subject: Re: [BUG/PATCH] Revert "gitk: Arrange to kill diff-files & diff-index on quit"
Date: Sat, 9 Aug 2008 13:13:52 +0400	[thread overview]
Message-ID: <200808091313.52528.angavrilov@gmail.com> (raw)
In-Reply-To: <42d19ab224653b2e6988d7209a8d3e87e19858f8.1218207346.git.christian@jaeger.mine.nu>

On Friday 08 August 2008 18:41:07 Christian Jaeger wrote:
> gitk would not show diffs (or trees when choosing tree view) about
> half of the times it is started, it would only show the commit
> messages. Sometimes it took dozens of times to get it to show a diff
> again with 3 starts, then the next 2 starts not, then the next 2
> starts would show it again, and so on.

> My system environment:
>   Debian Lenny (testing)
>   tk8.4 8.4.19-2

I cannot reproduce this on my Fedora 7 system with tk8.4.13 no matter how I try.
Could you please try to isolate which hunk causes the problem? You should be
able to remove them from bottom to top without any serious problems.


By the way, I experienced a similar problem while working on another patch
(although it required a more elaborate sequence of actions to trigger it), and
made a fix for it:

http://repo.or.cz/w/git.git?a=commitdiff;h=7272131b3e49879d3a7bedacad3cdb12ae678ee8

For some reason, now I cannot reproduce that either.

-- Alexander

  reply	other threads:[~2008-08-09  9:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08 14:41 [BUG/PATCH] Revert "gitk: Arrange to kill diff-files & diff-index on quit" Christian Jaeger
2008-08-09  9:13 ` Alexander Gavrilov [this message]
2008-08-09 10:04   ` [PATCH] gitk: make diff and tree display work reliably again Christian Jaeger
2008-08-09 10:41     ` [PATCH (GITK BUGFIX)] gitk: Allow safely calling nukefile from a run queue handler Alexander Gavrilov
2008-08-09 11:24       ` Christian Jaeger
2008-08-11  1:02         ` Christian Jaeger
2008-08-11 20:44           ` Junio C Hamano
2008-08-11  0:15       ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808091313.52528.angavrilov@gmail.com \
    --to=angavrilov@gmail.com \
    --cc=christian@jaeger.mine.nu \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.