From: Christian Jaeger <christian@jaeger.mine.nu>
To: Alexander Gavrilov <angavrilov@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH (GITK BUGFIX)] gitk: Allow safely calling nukefile from a run queue handler.
Date: Sat, 09 Aug 2008 13:24:23 +0200 [thread overview]
Message-ID: <489D7E67.5050205@jaeger.mine.nu> (raw)
In-Reply-To: <200808091441.50444.angavrilov@gmail.com>
Alexander Gavrilov wrote:
> Please test if this patch fixes it.
>
Yes, with that patch it works reliably.
BTW here's a patch to your patch to make it apply on top of 1.6.0.rc2:
--- patch.eml.1 2008-08-09 13:17:30.000000000 +0200
+++ patch.eml 2008-08-09 13:14:22.000000000 +0200
@@ -96,10 +96,10 @@
gitk | 14 ++++++++------
1 files changed, 8 insertions(+), 6 deletions(-)
-diff --git a/gitk b/gitk
-index b523c98..18d000c 100755
---- a/gitk
-+++ b/gitk
+diff --git a/gitk-git/gitk b/gitk-git/gitk
+index b523c98..18d000c 100644
+--- a/gitk-git/gitk
++++ b/gitk-git/gitk
@@ -22,11 +22,11 @@ proc gitdir {} {
# run before X event handlers, so reading from a fast source can
# make the GUI completely unresponsive.
Christian.
next prev parent reply other threads:[~2008-08-09 11:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 14:41 [BUG/PATCH] Revert "gitk: Arrange to kill diff-files & diff-index on quit" Christian Jaeger
2008-08-09 9:13 ` Alexander Gavrilov
2008-08-09 10:04 ` [PATCH] gitk: make diff and tree display work reliably again Christian Jaeger
2008-08-09 10:41 ` [PATCH (GITK BUGFIX)] gitk: Allow safely calling nukefile from a run queue handler Alexander Gavrilov
2008-08-09 11:24 ` Christian Jaeger [this message]
2008-08-11 1:02 ` Christian Jaeger
2008-08-11 20:44 ` Junio C Hamano
2008-08-11 0:15 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489D7E67.5050205@jaeger.mine.nu \
--to=christian@jaeger.mine.nu \
--cc=angavrilov@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.