All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <Laurent.Vivier@bull.net>, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/3] [x86] Clean up vendor identification
Date: Mon, 11 Aug 2008 14:04:32 +0100	[thread overview]
Message-ID: <200808111404.33988.paul@codesourcery.com> (raw)
In-Reply-To: <1218455786.3871.2.camel@frecb07144>

> > +#define CPUID_VENDOR_AMD_3   0x444d4163 /* "cAMD" */
>
> if you add "-Wno-multichar" in C flags, you can use:
>
> #define CPUID_VENDOR_INTEL_1 'Genu'

I recommend against doing this. The meaning of multi-character constants is 
implementation defined, and the gcc definition has changed at least once.

Paul

  parent reply	other threads:[~2008-08-11 13:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-11 10:37 [Qemu-devel] [PATCH 1/3] [x86] Clean up vendor identification Alexander Graf
2008-08-11 11:56 ` Laurent Vivier
2008-08-11 12:32   ` Alexander Graf
2008-08-11 12:50     ` Laurent Vivier
2008-08-11 13:37       ` M. Warner Losh
2008-08-11 14:05         ` Laurent Vivier
2008-08-11 12:56     ` Carlos A. M. dos Santos
2008-08-11 14:51       ` Paul Brook
2008-08-11 15:22         ` Carlos A. M. dos Santos
2008-08-11 13:04   ` Paul Brook [this message]
2008-08-11 13:35   ` M. Warner Losh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808111404.33988.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=Laurent.Vivier@bull.net \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.