All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Rene Herman <rene.herman@keyaccess.nl>
Cc: Andrew Morton <akpm@osdl.org>, Yinghai Lu <yhlu.kernel@gmail.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: kill arch/x86/kernel/mpparse.c debugging printk.
Date: Mon, 11 Aug 2008 18:38:55 +0200	[thread overview]
Message-ID: <20080811163855.GE4524@elte.hu> (raw)
In-Reply-To: <48A05E79.4030304@keyaccess.nl>


* Rene Herman <rene.herman@keyaccess.nl> wrote:

>> The way to make the printout depend on apic=debug/verbose is to do 
>> something like this:
>>
>> 	apic_printk(APIC_VERBOSE, "Scan SMP from %p for %ld bytes.\n", bp, length);
>>
>> Would you mind to send a patch for that?
>
> I wouldn't. Like this? This turns the printk's that used to be 
> Dprintk's into apic_printk's.

applied to tip/x86/urgent - thanks Rene.

> I am myself only interested in the one at the top of smp_scan_config() 
> (it made me think I had misconfigured something upon all of a sudden 
> seeing SMP printk's on my UP machine on 2.6.27-rc) but I guess this is 
> the more complete version.
>
> One problem; on 32-bit, "apic=" is a __setup() param and isn't 
> actually early enough for us here so this needs it turned into an 
> early_param() (followup).

good spotting, applied that one to tip/x86/urgent as well - thanks.

	Ingo

      parent reply	other threads:[~2008-08-11 16:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08 16:43 [PATCH] x86: kill arch/x86/kernel/mpparse.c debugging printk Rene Herman
2008-08-11 12:20 ` Ingo Molnar
2008-08-11 15:44   ` Rene Herman
2008-08-11 15:45     ` Rene Herman
2008-08-11 16:45       ` Cyrill Gorcunov
2008-08-11 17:20         ` Rene Herman
2008-08-11 17:41           ` Ingo Molnar
2008-08-11 18:06             ` Rene Herman
2008-08-11 18:33               ` Ingo Molnar
2008-08-11 18:42                 ` Cyrill Gorcunov
2008-08-11 18:46                   ` Cyrill Gorcunov
2008-08-11 18:49                   ` Ingo Molnar
2008-08-11 19:01                     ` Cyrill Gorcunov
2008-08-11 18:54                 ` Rene Herman
2008-08-11 16:38     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080811163855.GE4524@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rene.herman@keyaccess.nl \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.