From: Rene Herman <rene.herman@keyaccess.nl>
To: Andrew Morton <akpm@osdl.org>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: kill arch/x86/kernel/mpparse.c debugging printk.
Date: Fri, 08 Aug 2008 18:43:50 +0200 [thread overview]
Message-ID: <489C77C6.7040408@keyaccess.nl> (raw)
[-- Attachment #1: Type: text/plain, Size: 44 bytes --]
Hi Andrew.
<repeat below changelog>
Rene.
[-- Attachment #2: 0001-x86-kill-arch-x86-kernel-mpparse.c-debugging-printk.patch --]
[-- Type: text/plain, Size: 1310 bytes --]
>From 00acea21e579ea0853baba25420f373ea83533a3 Mon Sep 17 00:00:00 2001
From: Rene Herman <rene.herman@keyaccess.nl>
Date: Thu, 7 Aug 2008 01:50:35 +0200
Subject: [PATCH] x86: kill arch/x86/kernel/mpparse.c debugging printk.
commit 11a62a056093a7f25f1595fbd8bd5f93559572b6 turns some formerly
nopped debugging printks in arch/x86/kernel/mppparse.c into regular
ones. The one at the top of smp_scan_config() in particular also
prints on !CONFIG_SMP/CONFIG_X86_LOCAL_APIC kernels and UP machines
without anything resembling MP tables which makes their lowly UP
owners wonder...
given that it was up to this point also not considered valuable
user-level information, let's just kill that one.
Signed-off-by: Rene Herman <rene.herman@gmail.com>
---
arch/x86/kernel/mpparse.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c
index 6ae005c..519a6a9 100644
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -695,7 +695,6 @@ static int __init smp_scan_config(unsigned long base, unsigned long length,
unsigned int *bp = phys_to_virt(base);
struct intel_mp_floating *mpf;
- printk(KERN_DEBUG "Scan SMP from %p for %ld bytes.\n", bp, length);
BUILD_BUG_ON(sizeof(*mpf) != 16);
while (length > 0) {
--
1.5.5
next reply other threads:[~2008-08-08 16:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 16:43 Rene Herman [this message]
2008-08-11 12:20 ` [PATCH] x86: kill arch/x86/kernel/mpparse.c debugging printk Ingo Molnar
2008-08-11 15:44 ` Rene Herman
2008-08-11 15:45 ` Rene Herman
2008-08-11 16:45 ` Cyrill Gorcunov
2008-08-11 17:20 ` Rene Herman
2008-08-11 17:41 ` Ingo Molnar
2008-08-11 18:06 ` Rene Herman
2008-08-11 18:33 ` Ingo Molnar
2008-08-11 18:42 ` Cyrill Gorcunov
2008-08-11 18:46 ` Cyrill Gorcunov
2008-08-11 18:49 ` Ingo Molnar
2008-08-11 19:01 ` Cyrill Gorcunov
2008-08-11 18:54 ` Rene Herman
2008-08-11 16:38 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489C77C6.7040408@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.