From: Rusty Russell <rusty@rustcorp.com.au>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org, Matthew Wilcox <matthew@wil.cx>,
David Woodhouse <dwmw2@infradead.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linuxppc-dev@ozlabs.org
Subject: Re: [RFC 1/3] add support for exporting symbols from .S files
Date: Tue, 12 Aug 2008 12:03:56 +1000 [thread overview]
Message-ID: <200808121203.57182.rusty@rustcorp.com.au> (raw)
In-Reply-To: <200808111618.08206.arnd@arndb.de>
On Tuesday 12 August 2008 00:18:07 Arnd Bergmann wrote:
> This makes it possible to export symbols from assembly files, instead
> of having to export them through an extra ksyms.c file.
>
> I found this nicer to implement using a gas macro than a cpp macro.
...
> + .ifeq BITS_PER_LONG-32
> + .align 3
> +\symtab:
> + .long \sym
> + .long \strtab
> + .else
> + .align 4
Good work! Hmm, you can .balign BITS_PER_LONG/8 outside the ifeq.
Unfortunately .long doesn't do the Right Thing on 64 bit, so getting rid of
the if is harder.
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Cheers,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arch@vger.kernel.org, Matthew Wilcox <matthew@wil.cx>,
linux-kernel <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org, Al Viro <viro@zeniv.linux.org.uk>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [RFC 1/3] add support for exporting symbols from .S files
Date: Tue, 12 Aug 2008 12:03:56 +1000 [thread overview]
Message-ID: <200808121203.57182.rusty@rustcorp.com.au> (raw)
In-Reply-To: <200808111618.08206.arnd@arndb.de>
On Tuesday 12 August 2008 00:18:07 Arnd Bergmann wrote:
> This makes it possible to export symbols from assembly files, instead
> of having to export them through an extra ksyms.c file.
>
> I found this nicer to implement using a gas macro than a cpp macro.
...
> + .ifeq BITS_PER_LONG-32
> + .align 3
> +\symtab:
> + .long \sym
> + .long \strtab
> + .else
> + .align 4
Good work! Hmm, you can .balign BITS_PER_LONG/8 outside the ifeq.
Unfortunately .long doesn't do the Right Thing on 64 bit, so getting rid of
the if is harder.
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Cheers,
Rusty.
next prev parent reply other threads:[~2008-08-12 2:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 14:06 RFC: killing ksyms.c Arnd Bergmann
2008-08-11 14:17 ` [RFC 2/3] powerpc: export all symbols from the definition file Arnd Bergmann
2008-08-11 14:17 ` Arnd Bergmann
2008-08-11 14:53 ` Geert Uytterhoeven
2008-08-11 14:53 ` Geert Uytterhoeven
2008-08-11 15:27 ` Arnd Bergmann
2008-08-11 15:27 ` Arnd Bergmann
2008-08-11 14:18 ` [RFC 1/3] add support for exporting symbols from .S files Arnd Bergmann
2008-08-11 14:18 ` Arnd Bergmann
2008-08-11 14:56 ` David Woodhouse
2008-08-11 14:56 ` David Woodhouse
2008-08-12 2:03 ` Rusty Russell [this message]
2008-08-12 2:03 ` Rusty Russell
2008-08-12 6:43 ` Stephen Rothwell
2008-08-12 6:43 ` Stephen Rothwell
2008-08-12 13:58 ` Arnd Bergmann
2008-08-12 13:58 ` Arnd Bergmann
2008-08-11 14:25 ` [RFC 3/3] powerpc: remove ppc_ksyms.c Arnd Bergmann
2008-08-11 14:25 ` Arnd Bergmann
2008-08-11 15:03 ` RFC: killing ksyms.c Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808121203.57182.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=arnd@arndb.de \
--cc=dwmw2@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=matthew@wil.cx \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.