From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Split of raid scan code
Date: Tue, 12 Aug 2008 15:32:23 +0200 [thread overview]
Message-ID: <20080812133223.GB13942@thorin> (raw)
In-Reply-To: <ca0f59980808120449s61abd11iefb197cd3b1672d5@mail.gmail.com>
On Tue, Aug 12, 2008 at 07:49:19PM +0800, Bean wrote:
>
> Ok, I make some adjustment, now grub-install & update-grub works for
> raid device.
> [...]
> --- a/util/grub-probe.c
> +++ b/util/grub-probe.c
> @@ -142,7 +142,7 @@ probe (const char *path, char *device_name)
> abstraction_name = "lvm";
> break;
> case GRUB_DEV_ABSTRACTION_RAID:
> - abstraction_name = "raid";
> + abstraction_name = "raid mdraid";
Should be fine, I think.
> - buf += read_size;
> + buf += read_size << GRUB_DISK_SECTOR_BITS;
Felix told me this fixes a problem in current RAID code; when you check
your code in, please consider including this bugfix in a separate commit.
This makes it easier to track things.
Thanks!
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2008-08-12 13:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-10 11:52 [PATCH] Split of raid scan code Bean
2008-08-10 12:13 ` Felix Zielcke
2008-08-10 14:29 ` Robert Millan
2008-08-10 14:45 ` Bean
2008-08-10 15:49 ` Bean
2008-08-11 18:45 ` Bean
2008-08-11 20:13 ` Bean
2008-08-11 20:24 ` Bean
2008-08-11 20:30 ` Robert Millan
2008-08-12 11:49 ` Bean
2008-08-12 12:24 ` Felix Zielcke
2008-08-12 13:32 ` Robert Millan [this message]
2008-08-13 10:05 ` Marco Gerards
2008-08-13 18:43 ` Bean
2008-08-13 20:01 ` Bean
2008-08-16 9:07 ` Bean
2008-08-16 12:16 ` Robert Millan
2008-08-16 15:20 ` Bean
2008-08-17 14:19 ` Bean
2008-08-17 14:52 ` Robert Millan
2008-08-17 15:08 ` Bean
2008-08-17 15:23 ` Robert Millan
2008-08-18 17:20 ` Bean
2008-08-23 14:51 ` Bean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080812133223.GB13942@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.