All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Oester <kernel@linuxace.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] Pkttype match mismatches in OUTPUT chain
Date: Thu, 14 Aug 2008 05:02:40 -0700	[thread overview]
Message-ID: <20080814120240.GA30222@linuxace.com> (raw)
In-Reply-To: <48A2E268.6010808@trash.net>

On Wed, Aug 13, 2008 at 03:32:24PM +0200, Patrick McHardy wrote:
> This is getting more and more kludgy, wouldn't it make more sense
> to move the pkt_type initialisation from the device layer to the
> protocol layer?

It would, but that's a large-ish change, and unknown if DaveM would
support it just to make an iptables match less kludgy.  

Unfortunately, it doesn't appear this match was tested very thoroughly
prior to being added to the tree...

Phil

  reply	other threads:[~2008-08-14 12:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-10 22:18 [PATCH] Pkttype match mismatches in OUTPUT chain Phil Oester
2008-08-10 22:53 ` Phil Oester
2008-08-13 13:32   ` Patrick McHardy
2008-08-14 12:02     ` Phil Oester [this message]
2008-09-03 16:06       ` Phil Oester

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080814120240.GA30222@linuxace.com \
    --to=kernel@linuxace.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.