* [PATCH] x86, acpi: temp_stack is used only when CONFIG_SMP is set
@ 2008-08-03 16:52 Marcin Slusarz
2008-08-03 17:07 ` Sven Wegener
0 siblings, 1 reply; 6+ messages in thread
From: Marcin Slusarz @ 2008-08-03 16:52 UTC (permalink / raw)
To: LKML; +Cc: Glauber Costa, Pavel Machek, Ingo Molnar
arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Glauber Costa <gcosta@redhat.com>
Cc: Pavel Machek <pavel@suse.cz>
Cc: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/acpi/sleep.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
index fa2161d..9103cb6 100644
--- a/arch/x86/kernel/acpi/sleep.c
+++ b/arch/x86/kernel/acpi/sleep.c
@@ -20,7 +20,7 @@ unsigned long acpi_realmode_flags;
/* address in low memory of the wakeup routine. */
static unsigned long acpi_realmode;
-#ifdef CONFIG_64BIT
+#ifdef CONFIG_SMP
static char temp_stack[10240];
#endif
--
1.5.4.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG_SMP is set
2008-08-03 16:52 [PATCH] x86, acpi: temp_stack is used only when CONFIG_SMP is set Marcin Slusarz
@ 2008-08-03 17:07 ` Sven Wegener
2008-08-03 17:25 ` Marcin Slusarz
0 siblings, 1 reply; 6+ messages in thread
From: Sven Wegener @ 2008-08-03 17:07 UTC (permalink / raw)
To: Marcin Slusarz; +Cc: LKML, Glauber Costa, Pavel Machek, Ingo Molnar
On Sun, 3 Aug 2008, Marcin Slusarz wrote:
> arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Glauber Costa <gcosta@redhat.com>
> Cc: Pavel Machek <pavel@suse.cz>
> Cc: Ingo Molnar <mingo@elte.hu>
> ---
> arch/x86/kernel/acpi/sleep.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
> index fa2161d..9103cb6 100644
> --- a/arch/x86/kernel/acpi/sleep.c
> +++ b/arch/x86/kernel/acpi/sleep.c
> @@ -20,7 +20,7 @@ unsigned long acpi_realmode_flags;
> /* address in low memory of the wakeup routine. */
> static unsigned long acpi_realmode;
>
> -#ifdef CONFIG_64BIT
> +#ifdef CONFIG_SMP
> static char temp_stack[10240];
> #endif
>
Now it still generates the warning, but on i386 with CONFIG_SMP set,
instead of x86_64 without CONFIG_SMP. We only need temp_stack, when both
CONFIG_64BIT and CONFIG_SMP are activated.
Sven
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG_SMP is set
2008-08-03 17:07 ` Sven Wegener
@ 2008-08-03 17:25 ` Marcin Slusarz
2008-08-07 8:12 ` Pavel Machek
0 siblings, 1 reply; 6+ messages in thread
From: Marcin Slusarz @ 2008-08-03 17:25 UTC (permalink / raw)
To: Sven Wegener; +Cc: LKML, Glauber Costa, Pavel Machek, Ingo Molnar
On Sun, Aug 03, 2008 at 07:07:30PM +0200, Sven Wegener wrote:
> On Sun, 3 Aug 2008, Marcin Slusarz wrote:
>
> > arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used
> >
> > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> > Cc: Glauber Costa <gcosta@redhat.com>
> > Cc: Pavel Machek <pavel@suse.cz>
> > Cc: Ingo Molnar <mingo@elte.hu>
> > ---
> > arch/x86/kernel/acpi/sleep.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
> > index fa2161d..9103cb6 100644
> > --- a/arch/x86/kernel/acpi/sleep.c
> > +++ b/arch/x86/kernel/acpi/sleep.c
> > @@ -20,7 +20,7 @@ unsigned long acpi_realmode_flags;
> > /* address in low memory of the wakeup routine. */
> > static unsigned long acpi_realmode;
> >
> > -#ifdef CONFIG_64BIT
> > +#ifdef CONFIG_SMP
> > static char temp_stack[10240];
> > #endif
> >
>
> Now it still generates the warning, but on i386 with CONFIG_SMP set,
> instead of x86_64 without CONFIG_SMP. We only need temp_stack, when both
> CONFIG_64BIT and CONFIG_SMP are activated.
Yes. Thanks for looking at the patch!
---
>From c6e673acf02e8bf04866cadf17c1cb1fa4d852ea Mon Sep 17 00:00:00 2001
From: Marcin Slusarz <marcin.slusarz@gmail.com>
Subject: [PATCH] x86, acpi: temp_stack is used only when CONFIG_64BIT && CONFIG_SMP is set
arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Glauber Costa <gcosta@redhat.com>
Cc: Pavel Machek <pavel@suse.cz>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Sven Wegener <sven.wegener@stealer.net>
---
arch/x86/kernel/acpi/sleep.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
index fa2161d..81e5ab6 100644
--- a/arch/x86/kernel/acpi/sleep.c
+++ b/arch/x86/kernel/acpi/sleep.c
@@ -20,7 +20,7 @@ unsigned long acpi_realmode_flags;
/* address in low memory of the wakeup routine. */
static unsigned long acpi_realmode;
-#ifdef CONFIG_64BIT
+#if defined(CONFIG_SMP) && defined(CONFIG_64BIT)
static char temp_stack[10240];
#endif
--
1.5.4.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG_SMP is set
2008-08-03 17:25 ` Marcin Slusarz
@ 2008-08-07 8:12 ` Pavel Machek
2008-08-15 12:12 ` Marcin Slusarz
2008-08-15 14:41 ` Ingo Molnar
0 siblings, 2 replies; 6+ messages in thread
From: Pavel Machek @ 2008-08-07 8:12 UTC (permalink / raw)
To: Marcin Slusarz; +Cc: Sven Wegener, LKML, Glauber Costa, Ingo Molnar
Hi!
> > > arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used
> > >
> > > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> > > Cc: Glauber Costa <gcosta@redhat.com>
> > > Cc: Pavel Machek <pavel@suse.cz>
> > > Cc: Ingo Molnar <mingo@elte.hu>
> > > ---
> > > arch/x86/kernel/acpi/sleep.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
> > > index fa2161d..9103cb6 100644
> > > --- a/arch/x86/kernel/acpi/sleep.c
> > > +++ b/arch/x86/kernel/acpi/sleep.c
> > > @@ -20,7 +20,7 @@ unsigned long acpi_realmode_flags;
> > > /* address in low memory of the wakeup routine. */
> > > static unsigned long acpi_realmode;
> > >
> > > -#ifdef CONFIG_64BIT
> > > +#ifdef CONFIG_SMP
> > > static char temp_stack[10240];
> > > #endif
> > >
> >
> > Now it still generates the warning, but on i386 with CONFIG_SMP set,
> > instead of x86_64 without CONFIG_SMP. We only need temp_stack, when both
> > CONFIG_64BIT and CONFIG_SMP are activated.
>
> Yes. Thanks for looking at the patch!
>
> ---
> From c6e673acf02e8bf04866cadf17c1cb1fa4d852ea Mon Sep 17 00:00:00 2001
> From: Marcin Slusarz <marcin.slusarz@gmail.com>
> Subject: [PATCH] x86, acpi: temp_stack is used only when CONFIG_64BIT && CONFIG_SMP is set
>
> arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Glauber Costa <gcosta@redhat.com>
Acked-by: Pavel Machek <pavel@suse.cz>
Ingo, can you merge this one?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG_SMP is set
2008-08-07 8:12 ` Pavel Machek
@ 2008-08-15 12:12 ` Marcin Slusarz
2008-08-15 14:41 ` Ingo Molnar
1 sibling, 0 replies; 6+ messages in thread
From: Marcin Slusarz @ 2008-08-15 12:12 UTC (permalink / raw)
To: Pavel Machek; +Cc: Sven Wegener, LKML, Glauber Costa, Ingo Molnar
On Thu, Aug 07, 2008 at 10:12:46AM +0200, Pavel Machek wrote:
> Hi!
>
> > > > arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used
> > > >
> > > > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> > > > Cc: Glauber Costa <gcosta@redhat.com>
> > > > Cc: Pavel Machek <pavel@suse.cz>
> > > > Cc: Ingo Molnar <mingo@elte.hu>
> > > > ---
> > > > arch/x86/kernel/acpi/sleep.c | 2 +-
> > > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
> > > > index fa2161d..9103cb6 100644
> > > > --- a/arch/x86/kernel/acpi/sleep.c
> > > > +++ b/arch/x86/kernel/acpi/sleep.c
> > > > @@ -20,7 +20,7 @@ unsigned long acpi_realmode_flags;
> > > > /* address in low memory of the wakeup routine. */
> > > > static unsigned long acpi_realmode;
> > > >
> > > > -#ifdef CONFIG_64BIT
> > > > +#ifdef CONFIG_SMP
> > > > static char temp_stack[10240];
> > > > #endif
> > > >
> > >
> > > Now it still generates the warning, but on i386 with CONFIG_SMP set,
> > > instead of x86_64 without CONFIG_SMP. We only need temp_stack, when both
> > > CONFIG_64BIT and CONFIG_SMP are activated.
> >
> > Yes. Thanks for looking at the patch!
> >
> > ---
> > From c6e673acf02e8bf04866cadf17c1cb1fa4d852ea Mon Sep 17 00:00:00 2001
> > From: Marcin Slusarz <marcin.slusarz@gmail.com>
> > Subject: [PATCH] x86, acpi: temp_stack is used only when CONFIG_64BIT && CONFIG_SMP is set
> >
> > arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used
> >
> > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> > Cc: Glauber Costa <gcosta@redhat.com>
>
> Acked-by: Pavel Machek <pavel@suse.cz>
>
> Ingo, can you merge this one?
Should I resend this patch? Or is there anything wrong with second version?
Marcin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG_SMP is set
2008-08-07 8:12 ` Pavel Machek
2008-08-15 12:12 ` Marcin Slusarz
@ 2008-08-15 14:41 ` Ingo Molnar
1 sibling, 0 replies; 6+ messages in thread
From: Ingo Molnar @ 2008-08-15 14:41 UTC (permalink / raw)
To: Pavel Machek; +Cc: Marcin Slusarz, Sven Wegener, LKML, Glauber Costa
* Pavel Machek <pavel@suse.cz> wrote:
> > > Now it still generates the warning, but on i386 with CONFIG_SMP set,
> > > instead of x86_64 without CONFIG_SMP. We only need temp_stack, when both
> > > CONFIG_64BIT and CONFIG_SMP are activated.
> >
> > Yes. Thanks for looking at the patch!
> Acked-by: Pavel Machek <pavel@suse.cz>
>
> Ingo, can you merge this one?
applied to tip/x86/urgent - thanks.
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-08-15 14:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-03 16:52 [PATCH] x86, acpi: temp_stack is used only when CONFIG_SMP is set Marcin Slusarz
2008-08-03 17:07 ` Sven Wegener
2008-08-03 17:25 ` Marcin Slusarz
2008-08-07 8:12 ` Pavel Machek
2008-08-15 12:12 ` Marcin Slusarz
2008-08-15 14:41 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.