From: Tony Lindgren <tony@atomide.com>
To: Adrian Hunter <ext-adrian.hunter@nokia.com>
Cc: linux-omap@vger.kernel.org,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] [MTD] OneNAND OMAP3: add delay for GPIO
Date: Mon, 18 Aug 2008 15:33:20 +0300 [thread overview]
Message-ID: <20080818123319.GD17827@atomide.com> (raw)
In-Reply-To: <48A4103C.9090603@nokia.com>
* Adrian Hunter <ext-adrian.hunter@nokia.com> [080814 14:21]:
> On OMAP3, the driver was occasionally not seeing the GPIO
> interrupt. Adding a small delay of one register read
> eliminates the problem.
Pushing to linux-omap tree.
Tony
> Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
> ---
> drivers/mtd/onenand/omap2.c | 9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
> index 2bd8746..bf6bba5 100644
> --- a/drivers/mtd/onenand/omap2.c
> +++ b/drivers/mtd/onenand/omap2.c
> @@ -141,8 +141,13 @@ static int omap2_onenand_wait(struct mtd_info *mtd, int state)
>
> /* Turn interrupts on */
> syscfg = read_reg(c, ONENAND_REG_SYS_CFG1);
> - syscfg |= ONENAND_SYS_CFG1_IOBE;
> - write_reg(c, syscfg, ONENAND_REG_SYS_CFG1);
> + if (!(syscfg & ONENAND_SYS_CFG1_IOBE)) {
> + syscfg |= ONENAND_SYS_CFG1_IOBE;
> + write_reg(c, syscfg, ONENAND_REG_SYS_CFG1);
> + if (cpu_is_omap34xx())
> + /* Add a delay to let GPIO settle */
> + syscfg = read_reg(c, ONENAND_REG_SYS_CFG1);
> + }
>
> INIT_COMPLETION(c->irq_done);
> if (c->gpio_irq) {
> --
> 1.5.4.3
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Adrian Hunter <ext-adrian.hunter@nokia.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] [MTD] OneNAND OMAP3: add delay for GPIO
Date: Mon, 18 Aug 2008 15:33:20 +0300 [thread overview]
Message-ID: <20080818123319.GD17827@atomide.com> (raw)
In-Reply-To: <48A4103C.9090603@nokia.com>
* Adrian Hunter <ext-adrian.hunter@nokia.com> [080814 14:21]:
> On OMAP3, the driver was occasionally not seeing the GPIO
> interrupt. Adding a small delay of one register read
> eliminates the problem.
Pushing to linux-omap tree.
Tony
> Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
> ---
> drivers/mtd/onenand/omap2.c | 9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
> index 2bd8746..bf6bba5 100644
> --- a/drivers/mtd/onenand/omap2.c
> +++ b/drivers/mtd/onenand/omap2.c
> @@ -141,8 +141,13 @@ static int omap2_onenand_wait(struct mtd_info *mtd, int state)
>
> /* Turn interrupts on */
> syscfg = read_reg(c, ONENAND_REG_SYS_CFG1);
> - syscfg |= ONENAND_SYS_CFG1_IOBE;
> - write_reg(c, syscfg, ONENAND_REG_SYS_CFG1);
> + if (!(syscfg & ONENAND_SYS_CFG1_IOBE)) {
> + syscfg |= ONENAND_SYS_CFG1_IOBE;
> + write_reg(c, syscfg, ONENAND_REG_SYS_CFG1);
> + if (cpu_is_omap34xx())
> + /* Add a delay to let GPIO settle */
> + syscfg = read_reg(c, ONENAND_REG_SYS_CFG1);
> + }
>
> INIT_COMPLETION(c->irq_done);
> if (c->gpio_irq) {
> --
> 1.5.4.3
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-08-18 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 11:00 [PATCH] [MTD] OneNAND OMAP3: add delay for GPIO Adrian Hunter
2008-08-18 12:33 ` Tony Lindgren [this message]
2008-08-18 12:33 ` Tony Lindgren
2008-08-18 12:36 ` Artem Bityutskiy
2008-08-18 12:36 ` Artem Bityutskiy
2008-08-18 12:41 ` Tony Lindgren
2008-08-18 12:41 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818123319.GD17827@atomide.com \
--to=tony@atomide.com \
--cc=ext-adrian.hunter@nokia.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.