[PATCH] x86 iommu: remove unneeded parenthesis

[PATCH] x86 iommu: remove unneeded parenthesis

[Jiri Kosina]

The parenthesis in __iommu_queue_command() are not needed when assigning 
into 'target' variable.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>

diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index de39e1f..69b4d06 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -65,7 +65,7 @@ static int __iommu_queue_command(struct amd_iommu *iommu, struct iommu_cmd *cmd)
  	u8 *target;

  	tail = readl(iommu->mmio_base + MMIO_CMD_TAIL_OFFSET);
-	target = (iommu->cmd_buf + tail);
+	target = iommu->cmd_buf + tail;
  	memcpy_toio(target, cmd, sizeof(*cmd));
  	tail = (tail + sizeof(*cmd)) % iommu->cmd_buf_size;
  	head = readl(iommu->mmio_base + MMIO_CMD_HEAD_OFFSET);

Re: [PATCH] x86 iommu: remove unneeded parenthesis

[Ingo Molnar]

* Jiri Kosina <jkosina@suse.cz> wrote:

> The parenthesis in __iommu_queue_command() are not needed when assigning  
> into 'target' variable.
>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>

applied to tip/x86/urgent - thanks Jiri.

[ Btw., the patch was whitespace damaged (leading double spaces, etc.), 
  i fixed it up by hand. Please check Documentation/email-clients.txt. ]

	Ingo

Re: [PATCH] x86 iommu: remove unneeded parenthesis

[Jiri Kosina]

On Tue, 19 Aug 2008, Ingo Molnar wrote:

>> The parenthesis in __iommu_queue_command() are not needed when assigning
>> into 'target' variable.
>> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> applied to tip/x86/urgent - thanks Jiri.

Thanks.

> [ Btw., the patch was whitespace damaged (leading double spaces, etc.),
>  i fixed it up by hand. Please check Documentation/email-clients.txt. ]

Hmm, this is the first time ever my [al]pine to damage patch. I will 
investigate this, thanks for letting me know.

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] x86 iommu: remove unneeded parenthesis

[Joerg Roedel]

On Tue, Aug 19, 2008 at 02:13:55AM +0200, Jiri Kosina wrote:
> The parenthesis in __iommu_queue_command() are not needed when assigning into 'target' variable.
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> 
> diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
> index de39e1f..69b4d06 100644
> --- a/arch/x86/kernel/amd_iommu.c
> +++ b/arch/x86/kernel/amd_iommu.c
> @@ -65,7 +65,7 @@ static int __iommu_queue_command(struct amd_iommu *iommu, struct iommu_cmd *cmd)
>  	u8 *target;
> 
>  	tail = readl(iommu->mmio_base + MMIO_CMD_TAIL_OFFSET);
> -	target = (iommu->cmd_buf + tail);
> +	target = iommu->cmd_buf + tail;
>  	memcpy_toio(target, cmd, sizeof(*cmd));
>  	tail = (tail + sizeof(*cmd)) % iommu->cmd_buf_size;
>  	head = readl(iommu->mmio_base + MMIO_CMD_HEAD_OFFSET);
> 

True, thanks Jiri.

Acked-by: Joerg Roedel <joerg.roedel@amd.com>

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy