From: Rusty Russell <rusty@rustcorp.com.au>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Chris Wright <chrisw@sous-sol.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_balloon: fix towards_target when deflating balloon
Date: Tue, 19 Aug 2008 11:22:54 +1000 [thread overview]
Message-ID: <200808191122.54845.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1219097731-1224-1-git-send-email-aliguori@us.ibm.com>
On Tuesday 19 August 2008 08:15:31 Anthony Liguori wrote:
> - return v - vb->num_pages;
> + if (v < vb->num_pages)
> + return -(s64)(vb->num_pages - v);
> + else
> + return v - vb->num_pages;
With all due respect, WTF?
Did you mean:
return (s64)v - vb->num_pages;
I'm really amazed this bug got this far though...
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, Avi Kivity <avi@qumranet.com>,
virtualization@lists.linux-foundation.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Chris Wright <chrisw@sous-sol.org>
Subject: Re: [PATCH] virtio_balloon: fix towards_target when deflating balloon
Date: Tue, 19 Aug 2008 11:22:54 +1000 [thread overview]
Message-ID: <200808191122.54845.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1219097731-1224-1-git-send-email-aliguori@us.ibm.com>
On Tuesday 19 August 2008 08:15:31 Anthony Liguori wrote:
> - return v - vb->num_pages;
> + if (v < vb->num_pages)
> + return -(s64)(vb->num_pages - v);
> + else
> + return v - vb->num_pages;
With all due respect, WTF?
Did you mean:
return (s64)v - vb->num_pages;
I'm really amazed this bug got this far though...
Rusty.
next prev parent reply other threads:[~2008-08-19 1:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 22:15 [PATCH] virtio_balloon: fix towards_target when deflating balloon Anthony Liguori
2008-08-19 0:42 ` Linus Torvalds
2008-08-19 0:42 ` Linus Torvalds
2008-08-19 1:09 ` Anthony Liguori
2008-08-19 1:09 ` Anthony Liguori
2008-08-19 4:17 ` Linus Torvalds
2008-08-19 4:17 ` Linus Torvalds
2008-08-19 1:22 ` Rusty Russell [this message]
2008-08-19 1:22 ` Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2008-08-18 22:15 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808191122.54845.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=aliguori@us.ibm.com \
--cc=chrisw@sous-sol.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.