From: greg@kroah.com
To: Jeff Garzik <jgarzik@pobox.com>,
Linux USB kernel mailing list <linux-usb@vger.kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Denis Joseph Barrow <D.Barow@option.com>
Subject: [patch 02/02] hso: dev_kfree_skb crash fix
Date: Tue, 19 Aug 2008 18:07:55 -0700 [thread overview]
Message-ID: <20080820010755.GC3365@kroah.com> (raw)
In-Reply-To: <20080820010738.GA3365@kroah.com>
[-- Attachment #1: hso-dev_kfree_skb-crash-fix.patch --]
[-- Type: text/plain, Size: 702 bytes --]
From: Denis Joseph Barrow <D.Barow@option.com>
Fixes dev_kfree_skb happening too many times when hso_start_net_device
is called from hso_resume.
Signed-off-by: Denis Joseph Barrow <D.Barow@option.com>
Cc: Jeff Garzik <jgarzik@pobox.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/net/usb/hso.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -2613,6 +2613,7 @@ static int hso_resume(struct usb_interfa
"Transmitting lingering data\n");
hso_net_start_xmit(hso_net->skb_tx_buf,
hso_net->net);
+ hso_net->skb_tx_buf = NULL;
}
result = hso_start_net_device(network_table[i]);
if (result)
--
WARNING: multiple messages have this Message-ID (diff)
From: greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org
To: Jeff Garzik <jgarzik-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>,
Linux USB kernel mailing list
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Denis Joseph Barrow
<D.Barow-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
Subject: [patch 02/02] hso: dev_kfree_skb crash fix
Date: Tue, 19 Aug 2008 18:07:55 -0700 [thread overview]
Message-ID: <20080820010755.GC3365@kroah.com> (raw)
In-Reply-To: <20080820010738.GA3365-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: hso-dev_kfree_skb-crash-fix.patch --]
[-- Type: text/plain, Size: 1028 bytes --]
From: Denis Joseph Barrow <D.Barow-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
Fixes dev_kfree_skb happening too many times when hso_start_net_device
is called from hso_resume.
Signed-off-by: Denis Joseph Barrow <D.Barow-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
Cc: Jeff Garzik <jgarzik-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>
---
drivers/net/usb/hso.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -2613,6 +2613,7 @@ static int hso_resume(struct usb_interfa
"Transmitting lingering data\n");
hso_net_start_xmit(hso_net->skb_tx_buf,
hso_net->net);
+ hso_net->skb_tx_buf = NULL;
}
result = hso_start_net_device(network_table[i]);
if (result)
--
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-08-20 1:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080820010353.593820280@mini.kroah.org>
2008-08-20 1:07 ` [patch 00/02] 2 more hso.c patches greg
2008-08-20 1:07 ` greg-U8xfFu+wG4EAvxtiuMwx3w
2008-08-20 1:07 ` [patch 01/02] hso: icon 322 detection fix greg
2008-08-20 1:07 ` greg-U8xfFu+wG4EAvxtiuMwx3w
2008-08-27 9:37 ` Jeff Garzik
2008-08-27 9:37 ` Jeff Garzik
2008-08-27 10:54 ` hso driver dropping characters on serial port & hacky fix Denis Joseph Barrow
2008-08-27 10:54 ` Denis Joseph Barrow
2008-08-27 15:55 ` question wrt /drivers/char/tty_io.c in pre 2.6.16 code Denis Joseph Barrow
2008-08-27 16:19 ` Greg KH
2008-08-27 16:19 ` Greg KH
2008-08-27 16:37 ` Alan Cox
2008-08-27 16:37 ` Alan Cox
2008-08-28 7:47 ` Denis Joseph Barrow
2008-08-20 1:07 ` greg [this message]
2008-08-20 1:07 ` [patch 02/02] hso: dev_kfree_skb crash fix greg-U8xfFu+wG4EAvxtiuMwx3w
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080820010755.GC3365@kroah.com \
--to=greg@kroah.com \
--cc=D.Barow@option.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.