* Re: [PATCH 3/3]: of: Add some I2C mod aliases table entries for sparc64 systems.
@ 2008-08-21 22:52 ` Grant Likely
0 siblings, 0 replies; 8+ messages in thread
From: Grant Likely @ 2008-08-21 22:52 UTC (permalink / raw)
To: David Miller; +Cc: linuxppc-dev, sparclinux, paulus, devicetree-discuss
On Thu, Aug 21, 2008 at 1:10 AM, David Miller <davem@davemloft.net> wrote:
>
> of: Add some I2C mod aliases table entries for sparc64 systems.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
I'd like to see a comment above these three lines stating that they
appear in Sparc systems, but otherwise...
Acked-by: Grant Likely <grant.likely@secretlab.ca>
g.
> ---
> drivers/of/base.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index ad8ac1a..e849f69 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -410,7 +410,9 @@ struct of_modalias_table {
> char *modalias;
> };
> static struct of_modalias_table of_modalias_table[] = {
> - /* Empty for now; add entries as needed */
> + { "i2c-adm1031", "adm1031" },
> + { "i2c-at24c64", "24c64" },
> + { "i2c-at34c02", "spd" },
> };
>
> /**
> --
> 1.5.6.5.GIT
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 3/3]: of: Add some I2C mod aliases table entries for sparc64 systems.
@ 2008-08-21 22:52 ` Grant Likely
0 siblings, 0 replies; 8+ messages in thread
From: Grant Likely @ 2008-08-21 22:52 UTC (permalink / raw)
To: David Miller; +Cc: linuxppc-dev, sparclinux, paulus, devicetree-discuss
On Thu, Aug 21, 2008 at 1:10 AM, David Miller <davem@davemloft.net> wrote:
>
> of: Add some I2C mod aliases table entries for sparc64 systems.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
I'd like to see a comment above these three lines stating that they
appear in Sparc systems, but otherwise...
Acked-by: Grant Likely <grant.likely@secretlab.ca>
g.
> ---
> drivers/of/base.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index ad8ac1a..e849f69 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -410,7 +410,9 @@ struct of_modalias_table {
> char *modalias;
> };
> static struct of_modalias_table of_modalias_table[] = {
> - /* Empty for now; add entries as needed */
> + { "i2c-adm1031", "adm1031" },
> + { "i2c-at24c64", "24c64" },
> + { "i2c-at34c02", "spd" },
> };
>
> /**
> --
> 1.5.6.5.GIT
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 3/3]: of: Add some I2C mod aliases table entries for sparc64 systems.
2008-08-21 22:52 ` Grant Likely
(?)
@ 2008-08-21 22:55 ` David Miller
-1 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2008-08-21 22:55 UTC (permalink / raw)
To: grant.likely; +Cc: sparclinux, linuxppc-dev, devicetree-discuss, paulus
From: "Grant Likely" <grant.likely@secretlab.ca>
Date: Thu, 21 Aug 2008 16:52:32 -0600
> On Thu, Aug 21, 2008 at 1:10 AM, David Miller <davem@davemloft.net> wrote:
> >
> > of: Add some I2C mod aliases table entries for sparc64 systems.
> >
> > Signed-off-by: David S. Miller <davem@davemloft.net>
>
> I'd like to see a comment above these three lines stating that they
> appear in Sparc systems, but otherwise...
>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
Ok, I'll add that.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3]: of: Add some I2C mod aliases table entries for sparc64 systems.
@ 2008-08-21 22:55 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2008-08-21 22:55 UTC (permalink / raw)
To: grant.likely; +Cc: linuxppc-dev, sparclinux, paulus, devicetree-discuss
From: "Grant Likely" <grant.likely@secretlab.ca>
Date: Thu, 21 Aug 2008 16:52:32 -0600
> On Thu, Aug 21, 2008 at 1:10 AM, David Miller <davem@davemloft.net> wrote:
> >
> > of: Add some I2C mod aliases table entries for sparc64 systems.
> >
> > Signed-off-by: David S. Miller <davem@davemloft.net>
>
> I'd like to see a comment above these three lines stating that they
> appear in Sparc systems, but otherwise...
>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
Ok, I'll add that.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3]: of: Add some I2C mod aliases table entries for
@ 2008-08-21 22:55 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2008-08-21 22:55 UTC (permalink / raw)
To: grant.likely; +Cc: linuxppc-dev, sparclinux, paulus, devicetree-discuss
From: "Grant Likely" <grant.likely@secretlab.ca>
Date: Thu, 21 Aug 2008 16:52:32 -0600
> On Thu, Aug 21, 2008 at 1:10 AM, David Miller <davem@davemloft.net> wrote:
> >
> > of: Add some I2C mod aliases table entries for sparc64 systems.
> >
> > Signed-off-by: David S. Miller <davem@davemloft.net>
>
> I'd like to see a comment above these three lines stating that they
> appear in Sparc systems, but otherwise...
>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
Ok, I'll add that.
^ permalink raw reply [flat|nested] 8+ messages in thread