Re: [Qemu-devel] [5063] Parallel Port Direction Fix

[Aurelien Jarno <aurelien@aurel32.net>]

On Fri, Aug 22, 2008 at 03:04:22PM +0530, Vijay Kumar wrote:
> Aurelien Jarno wrote:
>> Modified: trunk/qemu-char.h
>> ===================================================================
>> --- trunk/qemu-char.h	2008-08-21 23:03:15 UTC (rev 5062)
>> +++ trunk/qemu-char.h	2008-08-22 08:57:09 UTC (rev 5063)
>> @@ -27,6 +27,7 @@
>>  #define CHR_IOCTL_PP_EPP_READ         9
>>  #define CHR_IOCTL_PP_EPP_WRITE_ADDR  10
>>  #define CHR_IOCTL_PP_EPP_WRITE       11
>> +#define CHR_IOCTL_PP_DATA_DIR        12
>>   #define CHR_IOCTL_SERIAL_SET_TIOCM   12
>>  #define CHR_IOCTL_SERIAL_GET_TIOCM   13
>
> Jarno, thanks for committing the patch. But it seems that now there are two IOCTL macros with the same value. To be safe we can move CHR_IOCTL_PP_DATA_DIR to 14.

Oh right, thanks. I have just applied what samuel suggested.

> Signed-off-by: Vijay Kumar <vijaykumar@bravegnu.org>
>
> Index: qemu/qemu-char.h
> ===================================================================
> --- qemu.orig/qemu-char.h	2008-08-22 15:02:12.000000000 +0530
> +++ qemu/qemu-char.h	2008-08-22 15:02:16.000000000 +0530
> @@ -27,11 +27,12 @@
> #define CHR_IOCTL_PP_EPP_READ         9
> #define CHR_IOCTL_PP_EPP_WRITE_ADDR  10
> #define CHR_IOCTL_PP_EPP_WRITE       11
> -#define CHR_IOCTL_PP_DATA_DIR        12
>
> #define CHR_IOCTL_SERIAL_SET_TIOCM   12
> #define CHR_IOCTL_SERIAL_GET_TIOCM   13
>
> +#define CHR_IOCTL_PP_DATA_DIR        14
> +
> #define CHR_TIOCM_CTS	0x020
> #define CHR_TIOCM_CAR	0x040
> #define CHR_TIOCM_DSR	0x100
>
>
>
>

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net