From: Vijay Kumar <vijaykumar@bravegnu.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5063] Parallel Port Direction Fix
Date: Fri, 22 Aug 2008 15:04:22 +0530 [thread overview]
Message-ID: <48AE881E.4060202@bravegnu.org> (raw)
In-Reply-To: <E1KWSSE-0004w1-J3@cvs.savannah.gnu.org>
Aurelien Jarno wrote:
> Modified: trunk/qemu-char.h
> ===================================================================
> --- trunk/qemu-char.h 2008-08-21 23:03:15 UTC (rev 5062)
> +++ trunk/qemu-char.h 2008-08-22 08:57:09 UTC (rev 5063)
> @@ -27,6 +27,7 @@
> #define CHR_IOCTL_PP_EPP_READ 9
> #define CHR_IOCTL_PP_EPP_WRITE_ADDR 10
> #define CHR_IOCTL_PP_EPP_WRITE 11
> +#define CHR_IOCTL_PP_DATA_DIR 12
>
> #define CHR_IOCTL_SERIAL_SET_TIOCM 12
> #define CHR_IOCTL_SERIAL_GET_TIOCM 13
Jarno, thanks for committing the patch. But it seems that now there are two IOCTL macros with the same value. To be safe we can move CHR_IOCTL_PP_DATA_DIR to 14.
Signed-off-by: Vijay Kumar <vijaykumar@bravegnu.org>
Index: qemu/qemu-char.h
===================================================================
--- qemu.orig/qemu-char.h 2008-08-22 15:02:12.000000000 +0530
+++ qemu/qemu-char.h 2008-08-22 15:02:16.000000000 +0530
@@ -27,11 +27,12 @@
#define CHR_IOCTL_PP_EPP_READ 9
#define CHR_IOCTL_PP_EPP_WRITE_ADDR 10
#define CHR_IOCTL_PP_EPP_WRITE 11
-#define CHR_IOCTL_PP_DATA_DIR 12
#define CHR_IOCTL_SERIAL_SET_TIOCM 12
#define CHR_IOCTL_SERIAL_GET_TIOCM 13
+#define CHR_IOCTL_PP_DATA_DIR 14
+
#define CHR_TIOCM_CTS 0x020
#define CHR_TIOCM_CAR 0x040
#define CHR_TIOCM_DSR 0x100
next prev parent reply other threads:[~2008-08-22 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 8:57 [Qemu-devel] [5063] Parallel Port Direction Fix Aurelien Jarno
2008-08-22 9:34 ` Vijay Kumar [this message]
2008-08-22 10:44 ` Samuel Thibault
2008-08-22 21:25 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AE881E.4060202@bravegnu.org \
--to=vijaykumar@bravegnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.