All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamie Lokier <jamie@shareable.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Giometti <giometti@enneenne.com>,
	Rodolfo@shareable.org, linux-kernel@vger.kernel.org,
	Zev Weiss <zevweiss@gmail.com>,
	linux-mtd@lists.infradead.org,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] [MTD] mtdchar.c: Fix regression in MEMGETREGIONINFO ioctl()
Date: Sun, 24 Aug 2008 13:38:34 +0100	[thread overview]
Message-ID: <20080824123834.GC24946@shareable.org> (raw)
In-Reply-To: <20080822153451.bb79bd1f.akpm@linux-foundation.org>

Andrew Morton wrote:
> struct mtd_erase_region_info {
> 	struct {
> 		u_int32_t offset;
> 		u_int32_t erasesize;
> 		u_int32_t numblocks;
> 	} user_part;
> 	unsigned long *lockmap;
> };

Is the name "struct mtd_erase_region_info" something userspace uses?

Nothing wrong with changing the kernel's version, as long as userspace
uses different headers, but it might be confusing.

-- Jamie

WARNING: multiple messages have this Message-ID (diff)
From: Jamie Lokier <jamie@shareable.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Zev Weiss <zevweiss@gmail.com>,
	Rodolfo@shareable.org, David Woodhouse <dwmw2@infradead.org>,
	Giometti <giometti@enneenne.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [MTD] mtdchar.c: Fix regression in MEMGETREGIONINFO ioctl()
Date: Sun, 24 Aug 2008 13:38:34 +0100	[thread overview]
Message-ID: <20080824123834.GC24946@shareable.org> (raw)
In-Reply-To: <20080822153451.bb79bd1f.akpm@linux-foundation.org>

Andrew Morton wrote:
> struct mtd_erase_region_info {
> 	struct {
> 		u_int32_t offset;
> 		u_int32_t erasesize;
> 		u_int32_t numblocks;
> 	} user_part;
> 	unsigned long *lockmap;
> };

Is the name "struct mtd_erase_region_info" something userspace uses?

Nothing wrong with changing the kernel's version, as long as userspace
uses different headers, but it might be confusing.

-- Jamie

  parent reply	other threads:[~2008-08-24 12:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-20  7:47 [PATCH] [MTD] mtdchar.c: Fix regression in MEMGETREGIONINFO ioctl() Zev Weiss
2008-08-22 22:34 ` Andrew Morton
2008-08-22 22:34   ` Andrew Morton
2008-08-23  8:10   ` Zev Weiss
2008-08-23  8:10     ` Zev Weiss
2008-08-24  5:27     ` Andrew Morton
2008-08-24  5:27       ` Andrew Morton
2008-08-24 11:01       ` Zev Weiss
2008-08-24 11:01         ` Zev Weiss
2008-08-27  4:31         ` Zev Weiss
2008-08-27  4:31           ` Zev Weiss
2008-09-01 11:01           ` David Woodhouse
2008-09-01 11:01             ` David Woodhouse
2008-09-01 12:19             ` Zev Weiss
2008-09-01 12:19               ` Zev Weiss
2008-09-01 17:25               ` David Woodhouse
2008-09-01 17:25                 ` David Woodhouse
2008-08-25 11:37       ` David Woodhouse
2008-08-25 11:37         ` David Woodhouse
2008-08-24 12:38   ` Jamie Lokier [this message]
2008-08-24 12:38     ` Jamie Lokier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080824123834.GC24946@shareable.org \
    --to=jamie@shareable.org \
    --cc=Rodolfo@shareable.org \
    --cc=akpm@linux-foundation.org \
    --cc=dwmw2@infradead.org \
    --cc=giometti@enneenne.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=zevweiss@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.