From: Jamie Lokier <jamie@shareable.org>
To: qemu-devel@nongnu.org
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Fix vfork() syscall emulation
Date: Sun, 24 Aug 2008 15:47:33 +0100 [thread overview]
Message-ID: <20080824144733.GB28033@shareable.org> (raw)
In-Reply-To: <1219450705-1376-1-git-send-email-kirill@shutemov.name>
Kirill A. Shutemov wrote:
> - if (flags & CLONE_VM) {
> + if (!(flags & CLONE_VFORK) && flags & CLONE_VM) {
Parentheses around (flags & CLONE_VM) would be good here.
-- Jamie
next prev parent reply other threads:[~2008-08-24 14:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-23 0:18 [Qemu-devel] [PATCH] Fix vfork() syscall emulation Kirill A. Shutemov
2008-08-24 14:47 ` Jamie Lokier [this message]
2008-08-24 15:51 ` Kirill A. Shutemov
-- strict thread matches above, loose matches on Subject: below --
2008-08-24 15:54 Kirill A. Shutemov
2008-09-08 14:03 Kirill A. Shutemov
2008-09-18 15:06 Kirill A. Shutemov
2008-09-20 2:56 ` andrzej zaborowski
2008-09-20 6:45 ` Kirill A. Shutemov
2008-09-20 12:45 ` andrzej zaborowski
2008-09-20 13:11 ` Kirill A. Shutemov
2008-09-20 13:52 ` andrzej zaborowski
2008-09-20 14:20 ` Kirill A. Shutemov
2008-09-20 14:35 ` andrzej zaborowski
2008-09-20 14:38 ` Kirill A. Shutemov
2008-09-20 7:12 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080824144733.GB28033@shareable.org \
--to=jamie@shareable.org \
--cc=kirill@shutemov.name \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.