From: Michael Buesch <mb@bu3sch.de>
To: Andreas Schwab <schwab@suse.de>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org
Subject: Re: Random crashes with 2.6.27-rc3 on PPC
Date: Sun, 24 Aug 2008 17:00:22 +0200 [thread overview]
Message-ID: <200808241700.22815.mb@bu3sch.de> (raw)
In-Reply-To: <je7ia6bhdd.fsf@sykes.suse.de>
On Sunday 24 August 2008 16:46:38 Andreas Schwab wrote:
> Michael Buesch <mb@bu3sch.de> writes:
>
> > The following workaround seems to fix the crashes on powerpc.
> > However, this patch is clearly not what we want for other architectures,
> > as they might need -fno-omit-frame-pointer to function properly.
>
> This has a better chance to be accepted. :-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 8b5a7d3..f9a2e48 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -394,7 +394,7 @@ config LOCKDEP
> bool
> depends on DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT
> select STACKTRACE
> - select FRAME_POINTER if !X86 && !MIPS
> + select FRAME_POINTER if !X86 && !MIPS && !PPC
> select KALLSYMS
> select KALLSYMS_ALL
This is not what my patch is doing.
Your patch always forces FRAME_POINTER off. At least as far as lockdep is concerned.
What about other parts of the kernel that enable FRAME_POINTER?
I think this should be fixed in the makefile by substitution of
-fno-omit-frame-pointer on PPC (and probably depending on the compiler
version).
Otherwise, if somebody else decides to do select FRAME_POINTER in some other
code, the bug will reappear.
I'm also not sure if it's desired to always force FRAME_POINTER off.
--
Greetings Michael.
WARNING: multiple messages have this Message-ID (diff)
From: Michael Buesch <mb@bu3sch.de>
To: Andreas Schwab <schwab@suse.de>
Cc: benh@kernel.crashing.org, linuxppc-dev@ozlabs.org,
Linus Torvalds <torvalds@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Random crashes with 2.6.27-rc3 on PPC
Date: Sun, 24 Aug 2008 17:00:22 +0200 [thread overview]
Message-ID: <200808241700.22815.mb@bu3sch.de> (raw)
In-Reply-To: <je7ia6bhdd.fsf@sykes.suse.de>
On Sunday 24 August 2008 16:46:38 Andreas Schwab wrote:
> Michael Buesch <mb@bu3sch.de> writes:
>
> > The following workaround seems to fix the crashes on powerpc.
> > However, this patch is clearly not what we want for other architectures,
> > as they might need -fno-omit-frame-pointer to function properly.
>
> This has a better chance to be accepted. :-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 8b5a7d3..f9a2e48 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -394,7 +394,7 @@ config LOCKDEP
> bool
> depends on DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT
> select STACKTRACE
> - select FRAME_POINTER if !X86 && !MIPS
> + select FRAME_POINTER if !X86 && !MIPS && !PPC
> select KALLSYMS
> select KALLSYMS_ALL
This is not what my patch is doing.
Your patch always forces FRAME_POINTER off. At least as far as lockdep is concerned.
What about other parts of the kernel that enable FRAME_POINTER?
I think this should be fixed in the makefile by substitution of
-fno-omit-frame-pointer on PPC (and probably depending on the compiler
version).
Otherwise, if somebody else decides to do select FRAME_POINTER in some other
code, the bug will reappear.
I'm also not sure if it's desired to always force FRAME_POINTER off.
--
Greetings Michael.
next prev parent reply other threads:[~2008-08-24 15:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-23 14:10 Random crashes with 2.6.27-rc3 on PPC Michael Buesch
2008-08-23 16:58 ` Arnaud Ebalard
2008-08-23 16:58 ` Arnaud Ebalard
2008-08-23 22:52 ` Benjamin Herrenschmidt
2008-08-24 7:23 ` Michael Buesch
2008-08-24 13:44 ` Michael Buesch
2008-08-24 13:44 ` Michael Buesch
2008-08-24 14:46 ` Andreas Schwab
2008-08-24 14:46 ` Andreas Schwab
2008-08-24 15:00 ` Michael Buesch [this message]
2008-08-24 15:00 ` Michael Buesch
2008-08-24 22:39 ` Benjamin Herrenschmidt
2008-08-24 22:39 ` Benjamin Herrenschmidt
2008-08-24 22:37 ` Benjamin Herrenschmidt
2008-08-24 22:37 ` Benjamin Herrenschmidt
2008-09-02 6:50 ` [PATCH 1/1] Work around the fomit-frame-pointer bug Tony Breeds
2008-09-02 6:50 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808241700.22815.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=schwab@suse.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.