From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] mini-os: make xenbus_read_integer and xenbus_printf take const strings
Date: Tue, 26 Aug 2008 17:42:06 +0100 [thread overview]
Message-ID: <20080826164206.GH4555@implementation.uk.xensource.com> (raw)
In-Reply-To: <20080826163437.GK19615@redhat.com>
Daniel P. Berrange, le Tue 26 Aug 2008 17:34:37 +0100, a écrit :
> If you annotate that declaration with
>
> __attribute__ ((__format__ (printf, 4, 3)))
>
> then gcc will warn you any time a caller gives incorrect args vs
> format string, which can catch some otherwise hidden bugs.
Indeed, actually all mini-os's *print* functions should have it, IIRC
there are a lot of fixes needed to have this compile with -Werror :)
Samuel
prev parent reply other threads:[~2008-08-26 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 16:17 [PATCH] mini-os: make xenbus_read_integer and xenbus_printf take const strings Samuel Thibault
2008-08-26 16:34 ` Daniel P. Berrange
2008-08-26 16:42 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080826164206.GH4555@implementation.uk.xensource.com \
--to=samuel.thibault@eu.citrix.com \
--cc=berrange@redhat.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.