From: Paul Mundt <lethal@linux-sh.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Magnus Damm <magnus.damm@gmail.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
video4linux-list@redhat.com,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA (was: Re: m68k allmodconfig)
Date: Wed, 27 Aug 2008 16:00:58 +0900 [thread overview]
Message-ID: <20080827070057.GA18717@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0808262035310.7910@anakin>
On Tue, Aug 26, 2008 at 09:37:21PM +0200, Geert Uytterhoeven wrote:
> Hi Andrew,
>
> On Thu, 14 Aug 2008, Andrew Morton wrote:
> > ERROR: "dma_alloc_coherent" [drivers/media/video/videobuf-dma-contig.ko] undefined!
> > ERROR: "dma_sync_single_for_cpu" [drivers/media/video/videobuf-dma-contig.ko] undefined!
> > ERROR: "dma_free_coherent" [drivers/media/video/videobuf-dma-contig.ko] undefined!
>
> M68k allmodconfig still selects Sun-3, which sets NO_DMA.
> I guess you're also seeing this on the other NO_DMA platforms (h8300, m32r,
> s390, and PCI-less SPARC)?
>
> Below is a patch.
>
> Shouldn't it also (or instead) depend on SUPERH or some SuperH platform?
> Or is this not done to have more compile-coverage?
>
The SUPERH dependency was there initially, but was dropped for increased
compilation coverage. The HAS_DMA dependence is certainly the right thing
to do here.
> Subject: [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA
>
> commit 0d3244d6439c8c31d2a29efd587c7aca9042c8aa ("V4L/DVB (8342):
> sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3") introduced
> VIDEO_SH_MOBILE_CEU, which selects VIDEOBUF_DMA_CONTIG. This circumvents the
> dependency on HAS_DMA of VIDEOBUF_DMA_CONTIG.
>
> Add a dependency on HAS_DMA to VIDEO_SH_MOBILE_CEU to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Paul Mundt <lethal@linux-sh.org>
next prev parent reply other threads:[~2008-08-27 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080814195522.ad74990c.akpm@linux-foundation.org>
2008-08-26 19:37 ` [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA (was: Re: m68k allmodconfig) Geert Uytterhoeven
2008-08-27 7:00 ` Paul Mundt [this message]
2008-08-27 9:41 ` Magnus Damm
2008-08-27 9:41 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080827070057.GA18717@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mchehab@infradead.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.