* [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA (was: Re: m68k allmodconfig) [not found] <20080814195522.ad74990c.akpm@linux-foundation.org> @ 2008-08-26 19:37 ` Geert Uytterhoeven 2008-08-27 7:00 ` Paul Mundt 2008-08-27 9:41 ` Magnus Damm 0 siblings, 2 replies; 4+ messages in thread From: Geert Uytterhoeven @ 2008-08-26 19:37 UTC (permalink / raw) To: Andrew Morton, Magnus Damm, Mauro Carvalho Chehab Cc: Paul Mundt, video4linux-list, Linux Kernel Development Hi Andrew, On Thu, 14 Aug 2008, Andrew Morton wrote: > ERROR: "dma_alloc_coherent" [drivers/media/video/videobuf-dma-contig.ko] undefined! > ERROR: "dma_sync_single_for_cpu" [drivers/media/video/videobuf-dma-contig.ko] undefined! > ERROR: "dma_free_coherent" [drivers/media/video/videobuf-dma-contig.ko] undefined! M68k allmodconfig still selects Sun-3, which sets NO_DMA. I guess you're also seeing this on the other NO_DMA platforms (h8300, m32r, s390, and PCI-less SPARC)? Below is a patch. Shouldn't it also (or instead) depend on SUPERH or some SuperH platform? Or is this not done to have more compile-coverage? Subject: [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA commit 0d3244d6439c8c31d2a29efd587c7aca9042c8aa ("V4L/DVB (8342): sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3") introduced VIDEO_SH_MOBILE_CEU, which selects VIDEOBUF_DMA_CONTIG. This circumvents the dependency on HAS_DMA of VIDEOBUF_DMA_CONTIG. Add a dependency on HAS_DMA to VIDEO_SH_MOBILE_CEU to fix this. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/media/video/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/video/Kconfig +++ b/drivers/media/video/Kconfig @@ -968,7 +968,7 @@ config VIDEO_PXA27x config VIDEO_SH_MOBILE_CEU tristate "SuperH Mobile CEU Interface driver" - depends on VIDEO_DEV + depends on VIDEO_DEV && HAS_DMA select SOC_CAMERA select VIDEOBUF_DMA_CONTIG ---help--- Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA (was: Re: m68k allmodconfig) 2008-08-26 19:37 ` [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA (was: Re: m68k allmodconfig) Geert Uytterhoeven @ 2008-08-27 7:00 ` Paul Mundt 2008-08-27 9:41 ` Magnus Damm 1 sibling, 0 replies; 4+ messages in thread From: Paul Mundt @ 2008-08-27 7:00 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Andrew Morton, Magnus Damm, Mauro Carvalho Chehab, video4linux-list, Linux Kernel Development On Tue, Aug 26, 2008 at 09:37:21PM +0200, Geert Uytterhoeven wrote: > Hi Andrew, > > On Thu, 14 Aug 2008, Andrew Morton wrote: > > ERROR: "dma_alloc_coherent" [drivers/media/video/videobuf-dma-contig.ko] undefined! > > ERROR: "dma_sync_single_for_cpu" [drivers/media/video/videobuf-dma-contig.ko] undefined! > > ERROR: "dma_free_coherent" [drivers/media/video/videobuf-dma-contig.ko] undefined! > > M68k allmodconfig still selects Sun-3, which sets NO_DMA. > I guess you're also seeing this on the other NO_DMA platforms (h8300, m32r, > s390, and PCI-less SPARC)? > > Below is a patch. > > Shouldn't it also (or instead) depend on SUPERH or some SuperH platform? > Or is this not done to have more compile-coverage? > The SUPERH dependency was there initially, but was dropped for increased compilation coverage. The HAS_DMA dependence is certainly the right thing to do here. > Subject: [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA > > commit 0d3244d6439c8c31d2a29efd587c7aca9042c8aa ("V4L/DVB (8342): > sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3") introduced > VIDEO_SH_MOBILE_CEU, which selects VIDEOBUF_DMA_CONTIG. This circumvents the > dependency on HAS_DMA of VIDEOBUF_DMA_CONTIG. > > Add a dependency on HAS_DMA to VIDEO_SH_MOBILE_CEU to fix this. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Paul Mundt <lethal@linux-sh.org> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA (was: Re: m68k allmodconfig) 2008-08-26 19:37 ` [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA (was: Re: m68k allmodconfig) Geert Uytterhoeven @ 2008-08-27 9:41 ` Magnus Damm 2008-08-27 9:41 ` Magnus Damm 1 sibling, 0 replies; 4+ messages in thread From: Magnus Damm @ 2008-08-27 9:41 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Andrew Morton, Mauro Carvalho Chehab, Paul Mundt, video4linux-list, Linux Kernel Development On Wed, Aug 27, 2008 at 4:37 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Hi Andrew, > > On Thu, 14 Aug 2008, Andrew Morton wrote: >> ERROR: "dma_alloc_coherent" [drivers/media/video/videobuf-dma-contig.ko] undefined! >> ERROR: "dma_sync_single_for_cpu" [drivers/media/video/videobuf-dma-contig.ko] undefined! >> ERROR: "dma_free_coherent" [drivers/media/video/videobuf-dma-contig.ko] undefined! > > M68k allmodconfig still selects Sun-3, which sets NO_DMA. > I guess you're also seeing this on the other NO_DMA platforms (h8300, m32r, > s390, and PCI-less SPARC)? > > Below is a patch. > > Shouldn't it also (or instead) depend on SUPERH or some SuperH platform? > Or is this not done to have more compile-coverage? > > Subject: [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA > > commit 0d3244d6439c8c31d2a29efd587c7aca9042c8aa ("V4L/DVB (8342): > sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3") introduced > VIDEO_SH_MOBILE_CEU, which selects VIDEOBUF_DMA_CONTIG. This circumvents the > dependency on HAS_DMA of VIDEOBUF_DMA_CONTIG. > > Add a dependency on HAS_DMA to VIDEO_SH_MOBILE_CEU to fix this. Thank you! > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Magnus Damm <damm@igel.co.jp> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA (was: Re: m68k allmodconfig) @ 2008-08-27 9:41 ` Magnus Damm 0 siblings, 0 replies; 4+ messages in thread From: Magnus Damm @ 2008-08-27 9:41 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Linux Kernel Development, Andrew Morton, Paul Mundt, video4linux-list, Mauro Carvalho Chehab On Wed, Aug 27, 2008 at 4:37 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Hi Andrew, > > On Thu, 14 Aug 2008, Andrew Morton wrote: >> ERROR: "dma_alloc_coherent" [drivers/media/video/videobuf-dma-contig.ko] undefined! >> ERROR: "dma_sync_single_for_cpu" [drivers/media/video/videobuf-dma-contig.ko] undefined! >> ERROR: "dma_free_coherent" [drivers/media/video/videobuf-dma-contig.ko] undefined! > > M68k allmodconfig still selects Sun-3, which sets NO_DMA. > I guess you're also seeing this on the other NO_DMA platforms (h8300, m32r, > s390, and PCI-less SPARC)? > > Below is a patch. > > Shouldn't it also (or instead) depend on SUPERH or some SuperH platform? > Or is this not done to have more compile-coverage? > > Subject: [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA > > commit 0d3244d6439c8c31d2a29efd587c7aca9042c8aa ("V4L/DVB (8342): > sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3") introduced > VIDEO_SH_MOBILE_CEU, which selects VIDEOBUF_DMA_CONTIG. This circumvents the > dependency on HAS_DMA of VIDEOBUF_DMA_CONTIG. > > Add a dependency on HAS_DMA to VIDEO_SH_MOBILE_CEU to fix this. Thank you! > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Magnus Damm <damm@igel.co.jp> -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-08-27 9:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20080814195522.ad74990c.akpm@linux-foundation.org>
2008-08-26 19:37 ` [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA (was: Re: m68k allmodconfig) Geert Uytterhoeven
2008-08-27 7:00 ` Paul Mundt
2008-08-27 9:41 ` Magnus Damm
2008-08-27 9:41 ` Magnus Damm
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.