From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] libxc: Use vcpu_guest_context_any_t instead of two pages
Date: Wed, 27 Aug 2008 15:45:57 +0100 [thread overview]
Message-ID: <20080827144557.GT4535@implementation.uk.xensource.com> (raw)
In-Reply-To: <C4DB1C31.267EA%keir.fraser@eu.citrix.com>
Keir Fraser, le Wed 27 Aug 2008 14:58:57 +0100, a écrit :
> This patch doesn't apply. You must have other patches layered underneath it.
Oops sorry, actually I had just mistakenly lowered all cases in the
patch (powerful editors...)
libxc: Use vcpu_guest_context_any_t instead of two pages
Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
diff -r 14a9a1629590 tools/libxc/xc_dom_boot.c
--- a/tools/libxc/xc_dom_boot.c wed aug 27 10:26:50 2008 +0100
+++ b/tools/libxc/xc_dom_boot.c wed aug 27 12:07:28 2008 +0100
@@ -187,7 +187,7 @@ int xc_dom_boot_image(struct xc_dom_imag
int xc_dom_boot_image(struct xc_dom_image *dom)
{
DECLARE_DOMCTL;
- void *ctxt;
+ vcpu_guest_context_any_t ctxt;
int rc;
xc_dom_printf("%s: called\n", __FUNCTION__);
@@ -245,12 +245,11 @@ int xc_dom_boot_image(struct xc_dom_imag
return rc;
/* let the vm run */
- ctxt = xc_dom_malloc(dom, PAGE_SIZE * 2 /* FIXME */ );
- memset(ctxt, 0, PAGE_SIZE * 2);
- if ( (rc = dom->arch_hooks->vcpu(dom, ctxt)) != 0 )
+ memset(&ctxt, 0, sizeof(ctxt));
+ if ( (rc = dom->arch_hooks->vcpu(dom, &ctxt)) != 0 )
return rc;
xc_dom_unmap_all(dom);
- rc = launch_vm(dom->guest_xc, dom->guest_domid, ctxt);
+ rc = launch_vm(dom->guest_xc, dom->guest_domid, &ctxt);
return rc;
}
prev parent reply other threads:[~2008-08-27 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 11:38 [PATCH] libxc: Use vcpu_guest_context_any_t instead of two pages Samuel Thibault
2008-08-27 13:58 ` Keir Fraser
2008-08-27 14:45 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080827144557.GT4535@implementation.uk.xensource.com \
--to=samuel.thibault@eu.citrix.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.