All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Samuel Thibault <samuel.thibault@eu.citrix.com>,
	xen-devel@lists.xensource.com
Subject: Re: [PATCH] libxc: Use vcpu_guest_context_any_t instead of two pages
Date: Wed, 27 Aug 2008 14:58:57 +0100	[thread overview]
Message-ID: <C4DB1C31.267EA%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <20080827113839.GP4535@implementation.uk.xensource.com>

This patch doesn't apply. You must have other patches layered underneath it.

 -- Keir

On 27/8/08 12:38, "Samuel Thibault" <samuel.thibault@eu.citrix.com> wrote:

> libxc: Use vcpu_guest_context_any_t instead of two pages
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
> 
> diff -r 14a9a1629590 tools/libxc/xc_dom_boot.c
> --- a/tools/libxc/xc_dom_boot.c wed aug 27 10:26:50 2008 +0100
> +++ b/tools/libxc/xc_dom_boot.c wed aug 27 12:07:28 2008 +0100
> @@ -187,7 +187,7 @@ int xc_dom_boot_image(struct xc_dom_imag
>  int xc_dom_boot_image(struct xc_dom_image *dom)
>  {
>      declare_domctl;
> -    void *ctxt;
> +    vcpu_guest_context_any_t ctxt;
>      int rc;
>  
>      xc_dom_printf("%s: called\n", __function__);
> @@ -245,12 +245,11 @@ int xc_dom_boot_image(struct xc_dom_imag
>          return rc;
>  
>      /* let the vm run */
> -    ctxt = xc_dom_malloc(dom, page_size * 2 /* fixme */ );
> -    memset(ctxt, 0, page_size * 2);
> -    if ( (rc = dom->arch_hooks->vcpu(dom, ctxt)) != 0 )
> +    memset(&ctxt, 0, sizeof(ctxt));
> +    if ( (rc = dom->arch_hooks->vcpu(dom, &ctxt)) != 0 )
>          return rc;
>      xc_dom_unmap_all(dom);
> -    rc = launch_vm(dom->guest_xc, dom->guest_domid, ctxt);
> +    rc = launch_vm(dom->guest_xc, dom->guest_domid, &ctxt);
>  
>      return rc;
>  }
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

  reply	other threads:[~2008-08-27 13:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-27 11:38 [PATCH] libxc: Use vcpu_guest_context_any_t instead of two pages Samuel Thibault
2008-08-27 13:58 ` Keir Fraser [this message]
2008-08-27 14:45   ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C4DB1C31.267EA%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=samuel.thibault@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.