From: Thiemo Seufer <ths@networkno.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] usb-linux.c: #define __user to work around broken Linux headers
Date: Thu, 28 Aug 2008 22:41:14 +0200 [thread overview]
Message-ID: <20080828204114.GD3229@networkno.de> (raw)
In-Reply-To: <48B70534.40103@codemonkey.ws>
Anthony Liguori wrote:
> Ian Jackson wrote:
>> Really we would like to #include <linux/compiler.h> but according
>> to changelogs in xen-unstable, at least FC6R3 doesn't have it.
>>
>> So instead we do this: we #define __user ourselves, which is
>> what <linux/compiler.h> does on systems which are not broken.
>>
>> (This change is identical to xen-unstable
>> 11601:ba7487569374378b398a1b134ea108a6a8209b4b.
>> and qemu-xen 1f153e0706851b43bb5c2083e531fd7b64b75be1.)
>>
>
> This was applied at one point in time, but then reverted IIRC. I think
> Fabrice objected?
It was rejected because distros should fix their broken headers instead.
Thiemo
next prev parent reply other threads:[~2008-08-28 20:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 16:24 [Qemu-devel] [PATCH] usb-linux.c: #define __user to work around broken Linux headers Ian Jackson
2008-08-28 20:06 ` Anthony Liguori
2008-08-28 20:41 ` Thiemo Seufer [this message]
2008-08-28 20:49 ` Anthony Liguori
2008-08-29 9:47 ` Ian Jackson
2008-09-07 2:50 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080828204114.GD3229@networkno.de \
--to=ths@networkno.de \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.