From: Anthony Liguori <anthony@codemonkey.ws>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] usb-linux.c: #define __user to work around broken Linux headers
Date: Sat, 06 Sep 2008 21:50:21 -0500 [thread overview]
Message-ID: <48C3416D.2050305@codemonkey.ws> (raw)
In-Reply-To: <18615.50622.311395.372416@mariner.uk.xensource.com>
Ian Jackson wrote:
> Thiemo Seufer writes ("Re: [Qemu-devel] [PATCH] usb-linux.c: #define __user to work around broken Linux headers"):
>
>> It was rejected because distros should fix their broken headers instead.
>>
>
> I think this is an absurd response.
>
I tend to agree with you. I think the proper fix though is not to
#define __user but to copy the Linux headers into QEMU and made sure
they compiled properly. I would apply a patch that did that.
Regards,
Anthony Liguori
prev parent reply other threads:[~2008-09-07 2:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 16:24 [Qemu-devel] [PATCH] usb-linux.c: #define __user to work around broken Linux headers Ian Jackson
2008-08-28 20:06 ` Anthony Liguori
2008-08-28 20:41 ` Thiemo Seufer
2008-08-28 20:49 ` Anthony Liguori
2008-08-29 9:47 ` Ian Jackson
2008-09-07 2:50 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C3416D.2050305@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=Ian.Jackson@eu.citrix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.