* [PATCH] x86: kill sys32_pause
@ 2008-09-01 1:39 Christoph Hellwig
2008-09-01 1:42 ` Christoph Hellwig
2008-09-01 16:14 ` Christoph Hellwig
0 siblings, 2 replies; 5+ messages in thread
From: Christoph Hellwig @ 2008-09-01 1:39 UTC (permalink / raw)
To: linux-kernel
It's just a duplicate of the native sys_pause.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/arch/x86/ia32/sys_ia32.c
===================================================================
--- linux-2.6.orig/arch/x86/ia32/sys_ia32.c 2008-08-22 12:48:34.000000000 -0300
+++ linux-2.6/arch/x86/ia32/sys_ia32.c 2008-08-22 12:48:40.000000000 -0300
@@ -556,15 +556,6 @@ asmlinkage long sys32_rt_sigqueueinfo(in
return ret;
}
-/* These are here just in case some old ia32 binary calls it. */
-asmlinkage long sys32_pause(void)
-{
- current->state = TASK_INTERRUPTIBLE;
- schedule();
- return -ERESTARTNOHAND;
-}
-
-
#ifdef CONFIG_SYSCTL_SYSCALL
struct sysctl_ia32 {
unsigned int name;
Index: linux-2.6/arch/ia64/ia32/ia32_entry.S
===================================================================
--- linux-2.6.orig/arch/ia64/ia32/ia32_entry.S 2008-08-22 12:49:25.000000000 -0300
+++ linux-2.6/arch/ia64/ia32/ia32_entry.S 2008-08-22 12:49:29.000000000 -0300
@@ -202,7 +202,7 @@ ia32_syscall_table:
data8 sys32_ptrace
data8 sys32_alarm
data8 sys_ni_syscall
- data8 sys32_pause
+ data8 sys_pause
data8 compat_sys_utime /* 30 */
data8 sys_ni_syscall /* old stty syscall holder */
data8 sys_ni_syscall /* old gtty syscall holder */
Index: linux-2.6/arch/ia64/ia32/sys_ia32.c
===================================================================
--- linux-2.6.orig/arch/ia64/ia32/sys_ia32.c 2008-08-22 12:49:33.000000000 -0300
+++ linux-2.6/arch/ia64/ia32/sys_ia32.c 2008-08-22 12:49:37.000000000 -0300
@@ -1795,14 +1795,6 @@ out:
}
asmlinkage int
-sys32_pause (void)
-{
- current->state = TASK_INTERRUPTIBLE;
- schedule();
- return -ERESTARTNOHAND;
-}
-
-asmlinkage int
sys32_msync (unsigned int start, unsigned int len, int flags)
{
unsigned int addr;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86: kill sys32_pause
2008-09-01 1:39 [PATCH] x86: kill sys32_pause Christoph Hellwig
@ 2008-09-01 1:42 ` Christoph Hellwig
2008-09-01 16:14 ` Christoph Hellwig
1 sibling, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2008-09-01 1:42 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-kernel, linux-ia64
On Mon, Sep 01, 2008 at 03:39:24AM +0200, Christoph Hellwig wrote:
> It's just a duplicate of the native sys_pause.
Oops, this also includes ia64. Should be safe anyway :)
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6/arch/x86/ia32/sys_ia32.c
> =================================> --- linux-2.6.orig/arch/x86/ia32/sys_ia32.c 2008-08-22 12:48:34.000000000 -0300
> +++ linux-2.6/arch/x86/ia32/sys_ia32.c 2008-08-22 12:48:40.000000000 -0300
> @@ -556,15 +556,6 @@ asmlinkage long sys32_rt_sigqueueinfo(in
> return ret;
> }
>
> -/* These are here just in case some old ia32 binary calls it. */
> -asmlinkage long sys32_pause(void)
> -{
> - current->state = TASK_INTERRUPTIBLE;
> - schedule();
> - return -ERESTARTNOHAND;
> -}
> -
> -
> #ifdef CONFIG_SYSCTL_SYSCALL
> struct sysctl_ia32 {
> unsigned int name;
> Index: linux-2.6/arch/ia64/ia32/ia32_entry.S
> =================================> --- linux-2.6.orig/arch/ia64/ia32/ia32_entry.S 2008-08-22 12:49:25.000000000 -0300
> +++ linux-2.6/arch/ia64/ia32/ia32_entry.S 2008-08-22 12:49:29.000000000 -0300
> @@ -202,7 +202,7 @@ ia32_syscall_table:
> data8 sys32_ptrace
> data8 sys32_alarm
> data8 sys_ni_syscall
> - data8 sys32_pause
> + data8 sys_pause
> data8 compat_sys_utime /* 30 */
> data8 sys_ni_syscall /* old stty syscall holder */
> data8 sys_ni_syscall /* old gtty syscall holder */
> Index: linux-2.6/arch/ia64/ia32/sys_ia32.c
> =================================> --- linux-2.6.orig/arch/ia64/ia32/sys_ia32.c 2008-08-22 12:49:33.000000000 -0300
> +++ linux-2.6/arch/ia64/ia32/sys_ia32.c 2008-08-22 12:49:37.000000000 -0300
> @@ -1795,14 +1795,6 @@ out:
> }
>
> asmlinkage int
> -sys32_pause (void)
> -{
> - current->state = TASK_INTERRUPTIBLE;
> - schedule();
> - return -ERESTARTNOHAND;
> -}
> -
> -asmlinkage int
> sys32_msync (unsigned int start, unsigned int len, int flags)
> {
> unsigned int addr;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
---end quoted text---
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86: kill sys32_pause
@ 2008-09-01 1:42 ` Christoph Hellwig
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2008-09-01 1:42 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-kernel, linux-ia64
On Mon, Sep 01, 2008 at 03:39:24AM +0200, Christoph Hellwig wrote:
> It's just a duplicate of the native sys_pause.
Oops, this also includes ia64. Should be safe anyway :)
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6/arch/x86/ia32/sys_ia32.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/ia32/sys_ia32.c 2008-08-22 12:48:34.000000000 -0300
> +++ linux-2.6/arch/x86/ia32/sys_ia32.c 2008-08-22 12:48:40.000000000 -0300
> @@ -556,15 +556,6 @@ asmlinkage long sys32_rt_sigqueueinfo(in
> return ret;
> }
>
> -/* These are here just in case some old ia32 binary calls it. */
> -asmlinkage long sys32_pause(void)
> -{
> - current->state = TASK_INTERRUPTIBLE;
> - schedule();
> - return -ERESTARTNOHAND;
> -}
> -
> -
> #ifdef CONFIG_SYSCTL_SYSCALL
> struct sysctl_ia32 {
> unsigned int name;
> Index: linux-2.6/arch/ia64/ia32/ia32_entry.S
> ===================================================================
> --- linux-2.6.orig/arch/ia64/ia32/ia32_entry.S 2008-08-22 12:49:25.000000000 -0300
> +++ linux-2.6/arch/ia64/ia32/ia32_entry.S 2008-08-22 12:49:29.000000000 -0300
> @@ -202,7 +202,7 @@ ia32_syscall_table:
> data8 sys32_ptrace
> data8 sys32_alarm
> data8 sys_ni_syscall
> - data8 sys32_pause
> + data8 sys_pause
> data8 compat_sys_utime /* 30 */
> data8 sys_ni_syscall /* old stty syscall holder */
> data8 sys_ni_syscall /* old gtty syscall holder */
> Index: linux-2.6/arch/ia64/ia32/sys_ia32.c
> ===================================================================
> --- linux-2.6.orig/arch/ia64/ia32/sys_ia32.c 2008-08-22 12:49:33.000000000 -0300
> +++ linux-2.6/arch/ia64/ia32/sys_ia32.c 2008-08-22 12:49:37.000000000 -0300
> @@ -1795,14 +1795,6 @@ out:
> }
>
> asmlinkage int
> -sys32_pause (void)
> -{
> - current->state = TASK_INTERRUPTIBLE;
> - schedule();
> - return -ERESTARTNOHAND;
> -}
> -
> -asmlinkage int
> sys32_msync (unsigned int start, unsigned int len, int flags)
> {
> unsigned int addr;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
---end quoted text---
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] x86: kill sys32_pause
2008-09-01 1:39 [PATCH] x86: kill sys32_pause Christoph Hellwig
2008-09-01 1:42 ` Christoph Hellwig
@ 2008-09-01 16:14 ` Christoph Hellwig
2008-09-06 16:45 ` Ingo Molnar
1 sibling, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2008-09-01 16:14 UTC (permalink / raw)
To: linux-kernel
It's an unused duplicate of the generic sys_pause.
(now without the b0rked ia64 bits, sorry)
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/arch/x86/ia32/sys_ia32.c
===================================================================
--- linux-2.6.orig/arch/x86/ia32/sys_ia32.c 2008-08-22 12:48:34.000000000 -0300
+++ linux-2.6/arch/x86/ia32/sys_ia32.c 2008-08-22 12:48:40.000000000 -0300
@@ -556,15 +556,6 @@ asmlinkage long sys32_rt_sigqueueinfo(in
return ret;
}
-/* These are here just in case some old ia32 binary calls it. */
-asmlinkage long sys32_pause(void)
-{
- current->state = TASK_INTERRUPTIBLE;
- schedule();
- return -ERESTARTNOHAND;
-}
-
-
#ifdef CONFIG_SYSCTL_SYSCALL
struct sysctl_ia32 {
unsigned int name;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86: kill sys32_pause
2008-09-01 16:14 ` Christoph Hellwig
@ 2008-09-06 16:45 ` Ingo Molnar
0 siblings, 0 replies; 5+ messages in thread
From: Ingo Molnar @ 2008-09-06 16:45 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-kernel
* Christoph Hellwig <hch@lst.de> wrote:
> It's an unused duplicate of the generic sys_pause.
>
> (now without the b0rked ia64 bits, sorry)
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
applied to tip/x86/cleanups - thanks Christoph. I'm curious, how did you
find it, some automation - or old-fashioned code reading?
Ingo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-09-06 16:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-01 1:39 [PATCH] x86: kill sys32_pause Christoph Hellwig
2008-09-01 1:42 ` Christoph Hellwig
2008-09-01 1:42 ` Christoph Hellwig
2008-09-01 16:14 ` Christoph Hellwig
2008-09-06 16:45 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.