From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] [ppc] Convert op_move_{T1,T2}_T0 to TCG
Date: Tue, 2 Sep 2008 18:19:04 +0200 [thread overview]
Message-ID: <20080902161904.GD23328@volta.aurel32.net> (raw)
In-Reply-To: <5FBA68BE-2F96-41D9-B032-BCA4A96557A7@web.de>
On Tue, Sep 02, 2008 at 05:39:17PM +0200, Andreas Färber wrote:
> Hello,
>
> Attached patch replaces op_move_T1_T0 and op_move_T2_T0 with
> tcg_gen_mov_tl.
>
> Signed-off-by: Andreas Faerber <andreas.faerber@web.de>
>
> Andreas
Applied, thanks.
>
>
> diff --git a/target-ppc/op.c b/target-ppc/op.c
> index 022d424..3ee326d 100644
> --- a/target-ppc/op.c
> +++ b/target-ppc/op.c
> @@ -137,18 +137,6 @@ void OPPROTO op_set_Rc0 (void)
> }
>
> /* Constants load */
> -void OPPROTO op_move_T1_T0 (void)
> -{
> - T1 = T0;
> - RETURN();
> -}
> -
> -void OPPROTO op_move_T2_T0 (void)
> -{
> - T2 = T0;
> - RETURN();
> -}
> -
> void OPPROTO op_moven_T2_T0 (void)
> {
> T2 = ~T0;
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 2c83056..cf6d486 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -795,7 +795,7 @@ __GEN_INT_ARITH1_O_64(name##o, opc1, opc2, opc3 |
> 0x10, type)
> /* add add. addo addo. */
> static always_inline void gen_op_addo (void)
> {
> - gen_op_move_T2_T0();
> + tcg_gen_mov_tl(cpu_T[2], cpu_T[0]);
> gen_op_add();
> gen_op_check_addo();
> }
> @@ -803,7 +803,7 @@ static always_inline void gen_op_addo (void)
> #define gen_op_add_64 gen_op_add
> static always_inline void gen_op_addo_64 (void)
> {
> - gen_op_move_T2_T0();
> + tcg_gen_mov_tl(cpu_T[2], cpu_T[0]);
> gen_op_add();
> gen_op_check_addo_64();
> }
> @@ -812,13 +812,13 @@ GEN_INT_ARITH2_64 (add, 0x1F, 0x0A, 0x08,
> PPC_INTEGER);
> /* addc addc. addco addco. */
> static always_inline void gen_op_addc (void)
> {
> - gen_op_move_T2_T0();
> + tcg_gen_mov_tl(cpu_T[2], cpu_T[0]);
> gen_op_add();
> gen_op_check_addc();
> }
> static always_inline void gen_op_addco (void)
> {
> - gen_op_move_T2_T0();
> + tcg_gen_mov_tl(cpu_T[2], cpu_T[0]);
> gen_op_add();
> gen_op_check_addc();
> gen_op_check_addo();
> @@ -826,13 +826,13 @@ static always_inline void gen_op_addco (void)
> #if defined(TARGET_PPC64)
> static always_inline void gen_op_addc_64 (void)
> {
> - gen_op_move_T2_T0();
> + tcg_gen_mov_tl(cpu_T[2], cpu_T[0]);
> gen_op_add();
> gen_op_check_addc_64();
> }
> static always_inline void gen_op_addco_64 (void)
> {
> - gen_op_move_T2_T0();
> + tcg_gen_mov_tl(cpu_T[2], cpu_T[0]);
> gen_op_add();
> gen_op_check_addc_64();
> gen_op_check_addo_64();
> @@ -842,14 +842,14 @@ GEN_INT_ARITH2_64 (addc, 0x1F, 0x0A, 0x00,
> PPC_INTEGER);
> /* adde adde. addeo addeo. */
> static always_inline void gen_op_addeo (void)
> {
> - gen_op_move_T2_T0();
> + tcg_gen_mov_tl(cpu_T[2], cpu_T[0]);
> gen_op_adde();
> gen_op_check_addo();
> }
> #if defined(TARGET_PPC64)
> static always_inline void gen_op_addeo_64 (void)
> {
> - gen_op_move_T2_T0();
> + tcg_gen_mov_tl(cpu_T[2], cpu_T[0]);
> gen_op_adde_64();
> gen_op_check_addo_64();
> }
> @@ -858,13 +858,13 @@ GEN_INT_ARITH2_64 (adde, 0x1F, 0x0A, 0x04,
> PPC_INTEGER);
> /* addme addme. addmeo addmeo. */
> static always_inline void gen_op_addme (void)
> {
> - gen_op_move_T1_T0();
> + tcg_gen_mov_tl(cpu_T[1], cpu_T[0]);
> gen_op_add_me();
> }
> #if defined(TARGET_PPC64)
> static always_inline void gen_op_addme_64 (void)
> {
> - gen_op_move_T1_T0();
> + tcg_gen_mov_tl(cpu_T[1], cpu_T[0]);
> gen_op_add_me_64();
> }
> #endif
> @@ -872,13 +872,13 @@ GEN_INT_ARITH1_64 (addme, 0x1F, 0x0A, 0x07,
> PPC_INTEGER);
> /* addze addze. addzeo addzeo. */
> static always_inline void gen_op_addze (void)
> {
> - gen_op_move_T2_T0();
> + tcg_gen_mov_tl(cpu_T[2], cpu_T[0]);
> gen_op_add_ze();
> gen_op_check_addc();
> }
> static always_inline void gen_op_addzeo (void)
> {
> - gen_op_move_T2_T0();
> + tcg_gen_mov_tl(cpu_T[2], cpu_T[0]);
> gen_op_add_ze();
> gen_op_check_addc();
> gen_op_check_addo();
> @@ -886,13 +886,13 @@ static always_inline void gen_op_addzeo (void)
> #if defined(TARGET_PPC64)
> static always_inline void gen_op_addze_64 (void)
> {
> - gen_op_move_T2_T0();
> + tcg_gen_mov_tl(cpu_T[2], cpu_T[0]);
> gen_op_add_ze();
> gen_op_check_addc_64();
> }
> static always_inline void gen_op_addzeo_64 (void)
> {
> - gen_op_move_T2_T0();
> + tcg_gen_mov_tl(cpu_T[2], cpu_T[0]);
> gen_op_add_ze();
> gen_op_check_addc_64();
> gen_op_check_addo_64();
> @@ -999,7 +999,7 @@ GEN_HANDLER(addic, 0x0C, 0xFF, 0xFF, 0x00000000,
> PPC_INTEGER)
>
> gen_op_load_gpr_T0(rA(ctx->opcode));
> if (likely(simm != 0)) {
> - gen_op_move_T2_T0();
> + tcg_gen_mov_tl(cpu_T[2], cpu_T[0]);
> gen_op_addi(simm);
> #if defined(TARGET_PPC64)
> if (ctx->sf_mode)
> @@ -1019,7 +1019,7 @@ GEN_HANDLER2(addic_, "addic.", 0x0D, 0xFF, 0xFF,
> 0x00000000, PPC_INTEGER)
>
> gen_op_load_gpr_T0(rA(ctx->opcode));
> if (likely(simm != 0)) {
> - gen_op_move_T2_T0();
> + tcg_gen_mov_tl(cpu_T[2], cpu_T[0]);
> gen_op_addi(simm);
> #if defined(TARGET_PPC64)
> if (ctx->sf_mode)
> @@ -1661,7 +1661,7 @@ GEN_HANDLER(srawi, 0x1F, 0x18, 0x19, 0x00000000,
> PPC_INTEGER)
> int mb, me;
> gen_op_load_gpr_T0(rS(ctx->opcode));
> if (SH(ctx->opcode) != 0) {
> - gen_op_move_T1_T0();
> + tcg_gen_mov_tl(cpu_T[1], cpu_T[0]);
> mb = 32 - SH(ctx->opcode);
> me = 31;
> #if defined(TARGET_PPC64)
> @@ -1691,7 +1691,7 @@ static always_inline void gen_sradi (DisasContext
> *ctx, int n)
> gen_op_load_gpr_T0(rS(ctx->opcode));
> sh = SH(ctx->opcode) + (n << 5);
> if (sh != 0) {
> - gen_op_move_T1_T0();
> + tcg_gen_mov_tl(cpu_T[1], cpu_T[0]);
> mb = 64 - SH(ctx->opcode);
> me = 63;
> mask = MASK(mb, me);
> @@ -4647,7 +4647,7 @@ static always_inline void gen_405_mulladd_insn
> (DisasContext *ctx,
> if (opc2 & 0x04) {
> /* (n)multiply-and-accumulate (0x0C - 0x0E) */
> gen_op_load_gpr_T2(rt);
> - gen_op_move_T1_T0();
> + tcg_gen_mov_tl(cpu_T[1], cpu_T[0]);
> gen_op_405_add_T0_T2();
> }
> if (opc3 & 0x10) {
>
>
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
next prev parent reply other threads:[~2008-09-02 16:19 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 13:36 [Qemu-devel] [PATCH] [ppc] Convert gen_set_{T0,T1} to TCG Andreas Färber
2008-09-02 14:32 ` [Qemu-devel] [PATCH] [ppc] Convert op_reset_T0, op_set_{T0, T1} " Andreas Färber
2008-09-02 15:39 ` [Qemu-devel] [PATCH] [ppc] Convert op_move_{T1,T2}_T0 " Andreas Färber
2008-09-02 16:19 ` Aurelien Jarno [this message]
2008-09-02 16:57 ` [Qemu-devel] [PATCH 4/x] [ppc] Convert op_moven_T2_T0 " Andreas Färber
2008-09-02 22:22 ` [Qemu-devel] [PATCH 5/x] ppc: Convert op_load_gpr_{T0,T1,T2} " Andreas Färber
2008-09-02 23:20 ` Aurelien Jarno
2008-09-03 0:39 ` [Qemu-devel] [PATCH 5/x] ppc: Convert op_load_gpr_{T0, T1, T2} " Andreas Färber
2008-09-03 5:07 ` Aurelien Jarno
2008-09-03 10:41 ` Andreas Färber
2008-09-03 11:28 ` Thiemo Seufer
2008-09-03 18:07 ` Andreas Färber
2008-09-03 18:26 ` Blue Swirl
2008-09-03 19:00 ` Andreas Färber
2008-09-03 19:12 ` Blue Swirl
2008-09-03 20:04 ` [Qemu-devel] [PATCH 5/x v2] ppc: Convert GPR moves " Andreas Färber
2008-09-04 5:25 ` Aurelien Jarno
2008-09-04 10:21 ` Andreas Färber
2008-09-04 12:24 ` [Qemu-devel] [PATCH 6/x] ppc: Convert Altivec register " Andreas Färber
2008-09-04 14:08 ` [Qemu-devel] [PATCH 7/x] ppc: Convert FPR " Andreas Färber
2008-09-04 14:39 ` Aurélien Jarno
2008-09-04 17:59 ` [Qemu-devel] [PATCH 8/x] ppc: Convert op_set_FT0 " Andreas Färber
2008-09-04 20:36 ` Aurélien Jarno
2008-09-04 22:53 ` [Qemu-devel] [PATCH 9/x] ppc: Convert op_add, op_addi " Andreas Färber
2008-09-05 14:18 ` Aurélien Jarno
2008-09-05 17:17 ` Andreas Färber
2008-09-05 17:49 ` Aurelien Jarno
2008-09-04 23:46 ` [Qemu-devel] [PATCH 10/x] ppc: Convert op_subf " Andreas Färber
2008-09-05 14:18 ` Aurélien Jarno
2008-09-04 14:39 ` [Qemu-devel] [PATCH 6/x] ppc: Convert Altivec register moves " Aurélien Jarno
2008-09-07 14:22 ` [Qemu-devel] [PATCH 5/x] ppc: Convert op_load_gpr_{T0, T1, T2} " Paul Brook
2008-09-03 12:41 ` Aurélien Jarno
2008-09-03 12:58 ` Andreas Färber
2008-09-03 13:00 ` Aurélien Jarno
2008-09-03 13:23 ` Thiemo Seufer
2008-09-03 13:45 ` Tristan Gingold
2008-09-03 16:04 ` Andreas Färber
2008-09-02 23:27 ` [Qemu-devel] [PATCH 4/x] [ppc] Convert op_moven_T2_T0 " Aurélien Jarno
2008-09-02 15:58 ` [Qemu-devel] [PATCH] [ppc] Convert op_reset_T0, op_set_{T0, T1} " Aurelien Jarno
2008-09-02 16:44 ` [Qemu-devel] [PATCH 2/x v2] " Andreas Färber
2008-09-02 23:28 ` Aurélien Jarno
2008-09-02 16:18 ` [Qemu-devel] [PATCH] [ppc] Convert gen_set_{T0,T1} " Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080902161904.GD23328@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.