All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] fix disk->id abuse
Date: Tue, 2 Sep 2008 21:21:11 +0200	[thread overview]
Message-ID: <20080902192111.GB9070@thorin> (raw)
In-Reply-To: <87abeqlkjd.fsf@xs4all.nl>

On Tue, Sep 02, 2008 at 03:55:18PM +0200, Marco Gerards wrote:
> 
> [...]
> 
> >> We could write a macro for ID comparison that would compare both the
> >> "driver ID" (disk->dev->id) and "device ID" (disk->id).  In this case,
> >> we can omit disk->id initialization in the drivers supporting only one
> >> device (e.g. memdisk) and only leave it where it's indeed needed for
> >> identifying separate devices, thus removing potentially confusing code.
> >
> > Sounds fine, although what worries me most if the current usage of 'id' in
> > scsi.c, which can lead to collision already.
> >
> > I assume using LUNs is a proper solution for that one?
> 
> No, it is not.  I think I already said so on IRC?

If you did, I must have missed it.  In any case, what can we use instead of
that?

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."



      parent reply	other threads:[~2008-09-02 19:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-30 12:26 [PATCH] fix disk->id abuse Robert Millan
2008-08-30 15:41 ` Pavel Roskin
2008-08-31 13:33   ` Robert Millan
2008-09-01 23:39     ` Pavel Roskin
2008-09-02 13:40       ` Robert Millan
2008-09-02 13:55         ` Marco Gerards
2008-09-02 19:12           ` Christian Franke
2008-09-02 19:24             ` Robert Millan
2008-09-02 19:43               ` Christian Franke
2008-09-02 19:21           ` Robert Millan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080902192111.GB9070@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.