From: Heikki Orsila <shd@modeemi.fi>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Re* [PATCH] Add --filedirstat diff option
Date: Wed, 3 Sep 2008 03:39:17 +0300 [thread overview]
Message-ID: <20080903003916.GD1252@jolt.modeemi.cs.tut.fi> (raw)
In-Reply-To: <7vbpz6dqd0.fsf_-_@gitster.siamese.dyndns.org>
On Tue, Sep 02, 2008 at 05:28:59PM -0700, Junio C Hamano wrote:
> But you are right to point out that --cumulative is an option that affects
> how --dirstat operates. And I think the option parsing of that code is
> buggy. It should imply --dirstat, shouldn't it?
Yes.
> Here is a sample patch to fix --cumulative (but of course it is untested);
> I think your --filemode (or whatever its final name is) should hook into
> the same place as this patch touches, as far as command line parsing is
> concerned.
I'll prepare something later today..
--
Heikki Orsila
heikki.orsila@iki.fi
http://www.iki.fi/shd
next prev parent reply other threads:[~2008-09-03 0:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 1:12 [PATCH] Add --filedirstat diff option Heikki Orsila
2008-09-02 6:57 ` Junio C Hamano
2008-09-02 11:58 ` Heikki Orsila
2008-09-02 23:40 ` Junio C Hamano
2008-09-02 23:55 ` Junio C Hamano
2008-09-03 0:08 ` Heikki Orsila
2008-09-03 0:28 ` Re* " Junio C Hamano
2008-09-03 0:39 ` Heikki Orsila [this message]
2008-09-03 0:12 ` Jeff King
2008-09-03 0:18 ` Heikki Orsila
2008-09-03 0:44 ` Junio C Hamano
2008-09-03 12:47 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080903003916.GD1252@jolt.modeemi.cs.tut.fi \
--to=shd@modeemi.fi \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.