From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Heikki Orsila <shd@modeemi.fi>, git@vger.kernel.org
Subject: Re: [PATCH] Add --filedirstat diff option
Date: Tue, 02 Sep 2008 17:44:55 -0700 [thread overview]
Message-ID: <7v7i9udpmg.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080903001254.GA12263@coredump.intra.peff.net> (Jeff King's message of "Tue, 2 Sep 2008 20:12:54 -0400")
Jeff King <peff@peff.net> writes:
> On Tue, Sep 02, 2008 at 04:55:39PM -0700, Junio C Hamano wrote:
>
>> "filedirstat" is simply too long to type, and it has a certain "Huh?"
>> factor --- is it about file, or is it about directory?
>
> I had the same thought when I saw the original patch...
>
>> This option essentially is just the dirstat but with different logic to
>> compute how big the damage is. Conceptually, the original one gives one
>> "damage point" to each added or deleted line.
>>
>> $ git show --dirstat=<one-point-per-line>
>
> ...and I thought of --dirstat-byfile. So maybe:
>
> --dirstat=byfile
>
> and
>
> --dirstat=byline
>
> defaulting to byline (or by-line if preferred).
As Heikki points out (and I missed this initially myself), --dirstat[=x]
already exists and it gives the cut-off-point.
Perhaps "--dirstat-by-file" that implies "--dirstat" (with the
understanding (and documentation) that "--dirstat" is a shorthand for
"--dirstat-by-line" that does not exist)?
next prev parent reply other threads:[~2008-09-03 0:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 1:12 [PATCH] Add --filedirstat diff option Heikki Orsila
2008-09-02 6:57 ` Junio C Hamano
2008-09-02 11:58 ` Heikki Orsila
2008-09-02 23:40 ` Junio C Hamano
2008-09-02 23:55 ` Junio C Hamano
2008-09-03 0:08 ` Heikki Orsila
2008-09-03 0:28 ` Re* " Junio C Hamano
2008-09-03 0:39 ` Heikki Orsila
2008-09-03 0:12 ` Jeff King
2008-09-03 0:18 ` Heikki Orsila
2008-09-03 0:44 ` Junio C Hamano [this message]
2008-09-03 12:47 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2008-09-02 23:51 Heikki Orsila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7i9udpmg.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=shd@modeemi.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.