Re: [PATCH] Show memory section to node relationship in sysfs

[Gary Hade <garyhade@us.ibm.com>]

On Thu, Sep 04, 2008 at 06:21:10PM -0700, Greg KH wrote:
> On Thu, Sep 04, 2008 at 06:15:00PM -0700, Gary Hade wrote:
> > On Thu, Sep 04, 2008 at 05:40:44PM -0700, Greg KH wrote:
> > > On Thu, Sep 04, 2008 at 03:15:46PM -0700, Dave Hansen wrote:
> > > > On Thu, 2008-09-04 at 13:22 -0700, Gary Hade wrote:
> > > > > 
> > > > > --- linux-2.6.27-rc5.orig/drivers/base/memory.c 2008-09-03 14:24:54.000000000 -0700
> > > > > +++ linux-2.6.27-rc5/drivers/base/memory.c      2008-09-03 14:25:14.000000000 -0700
> > > > > @@ -150,6 +150,22 @@
> > > > >         return len;
> > > > >  }
> > > > > 
> > > > > +/*
> > > > > + * node on which memory section resides
> > > > > + */
> > > > > +static ssize_t show_mem_node(struct sys_device *dev,
> > > > > +                       struct sysdev_attribute *attr, char *buf)
> > > > > +{
> > > > > +       unsigned long start_pfn;
> > > > > +       int ret;
> > > > > +       struct memory_block *mem =
> > > > > +               container_of(dev, struct memory_block, sysdev);
> > > > > +
> > > > > +       start_pfn = section_nr_to_pfn(mem->phys_index);
> > > > > +       ret = pfn_to_nid(start_pfn);
> > > > > +       return sprintf(buf, "%d\n", ret);
> > > > > +}
> > > > 
> > > > I only wonder if this is the "sysfs" way to do it.
> > > > 
> > > > I mean, we don't put a file with the PCI id of a device in the device's
> > > > sysfs directory.  We put a symlink to its place in the bus tree.
> > > > 
> > > > Should we just link over to the NUMA node directory?  We have it there,
> > > > so we might as well use it.
> > > 
> > > That sounds reasonable to me.  Someone is documenting this new addition
> > > with an entry in Documentation/ABI/, right?
> > 
> > Yes, my bad.  Revision will add that to Documentation/memory-hotplug.txt
> > as well as a description of the 'removable' file that Badari mentioned,
> > if OK to include both in the same patch.
> 
> Care to move the information from memory-hotplug.txt into the proper
> place for this kind of stuff (Documentation/ABI for all external kernel
> ABIs).

Sorry, I think I got it now.  Badari has already documented the
memory section 'removable' file in
  Documentation/ABI/testing/sysfs-devices-memory
but descriptions for the other memory section files are not yet
included there.  I will make sure this gets fixed.

Gary

-- 
Gary Hade
System x Enablement
IBM Linux Technology Center
503-578-4503  IBM T/L: 775-4503
garyhade@us.ibm.com
http://www.ibm.com/linux/ltc

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>