Re: [PATCH] Show memory section to node relationship in sysfs

[Badari Pulavarty <pbadari@us.ibm.com>]

Nish Aravamudan wrote:
> On 9/4/08, Gary Hade <garyhade@us.ibm.com> wrote:
>   
>> Show memory section to node relationship in sysfs
>>
>>  Add /sys/devices/system/memory/memoryX/node files to show
>>  the node on which each memory section resides.
>>     
>
> I think this patch needs an additional bit for Documentation/ABI
> (might be other parts of /sys/devices/system/memory missing from
> there).
>
>   
Yes. I added Documentation/ABI for "removable". We should update it for 
this too.
> Also, I wonder if it might not make more sense to use a symlink here? That is
>
> /sys/devices/system/memory/memoryX/node -> /sys/devices/system/node/nodeY ?
>
>   
Makes sense. Since we already have "node/nodeY", we might as well make 
use of it
instead of duplicating it.
> And then we could, potentially, have symlinks returning from the node
> side to indicate all memory sections on that node (might be handy for
> node offline?):
>
> /sys/devices/system/node/nodeX/memory1 -> /sys/devices/system/memory/memoryY
> /sys/devices/system/node/nodeX/memory2 -> /sys/devices/system/memory/memoryZ
>
>   
I don't think we need both. Gary wants to do "node removal/offline" and 
wants
to find out all the memory sections that belong to nodeX. May be this is a
a better interface. This way, we can quickly get through all the memory 
sections
without looking at all the sections. Gary ?
> Dunno, the latter probably should be a separate patch, but does seem
> more like the sysfs behavior (and the number (node or memory section)
> should be easily obtained from the symlinks via readlink, as opposed
> to cat with the current patch?).
>
> Thanks,
> Nish
>   

Thanks,
Badari

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>