From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
Michael Buesch <mb@bu3sch.de>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: make conf_tx non-atomic
Date: Sat, 6 Sep 2008 19:50:36 +0200 [thread overview]
Message-ID: <200809061950.36213.IvDoorn@gmail.com> (raw)
In-Reply-To: <1220717588.5376.0.camel@johannes.berg>
On Saturday 06 September 2008, Johannes Berg wrote:
> The conf_tx callback currently needs to be atomic, this requirement
> is just because it can be called from scanning. This rearranges it
> slightly to only update while not scanning (which is fine, we'll be
> getting beacons when associated) and thus removes the atomic
> requirement.
Oops. Ehm how many oopses were reported since I submitted patch:
47909b24a7e6c67ad635f36f5312839e04c7617c
rt2x00: Initialize txop during conf_tx() callback
Because apparently that patch broke rt73usb (I completely overlooked
the conf_tx() atomic requirements). :S
Fortunately this patch would fix it again. :)
> /* Do not send changes to driver if we are scanning. This removes
> - * requirement that driver's bss_info_changed function needs to be
> - * atomic. */
> + * requirement that a driver's bss_info_changed/conf_tx functions
> + * need to be atomic.
> + * This is really ugly code, we should rewrite scanning and make
> + * all this more understandable for humans.
> + */
So bss_info_changed() is now non-atomic as well? Because that would be
very useful for rt2x00. :)
Ivo
next prev parent reply other threads:[~2008-09-06 17:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-06 16:13 [PATCH] mac80211: make conf_tx non-atomic Johannes Berg
2008-09-06 17:50 ` Ivo van Doorn [this message]
2008-09-06 18:28 ` Johannes Berg
2008-09-06 22:43 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809061950.36213.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.