Re: [PATCH] mac80211: make conf_tx non-atomic

[Ivo van Doorn <ivdoorn@gmail.com>]

On Saturday 06 September 2008, Johannes Berg wrote:
> On Sat, 2008-09-06 at 19:50 +0200, Ivo van Doorn wrote:
> > On Saturday 06 September 2008, Johannes Berg wrote:
> > > The conf_tx callback currently needs to be atomic, this requirement
> > > is just because it can be called from scanning. This rearranges it
> > > slightly to only update while not scanning (which is fine, we'll be
> > > getting beacons when associated) and thus removes the atomic
> > > requirement.
> > 
> > Oops. Ehm how many oopses were reported since I submitted patch:
> > 	47909b24a7e6c67ad635f36f5312839e04c7617c
> > 	rt2x00: Initialize txop during conf_tx() callback
> > 
> > Because apparently that patch broke rt73usb (I completely overlooked
> > the conf_tx() atomic requirements). :S
> 
> Heh, I don't know.
> 
> > Fortunately this patch would fix it again. :)
> 
> :)
> 
> > >  	/* Do not send changes to driver if we are scanning. This removes
> > > -	 * requirement that driver's bss_info_changed function needs to be
> > > -	 * atomic. */
> > > +	 * requirement that a driver's bss_info_changed/conf_tx functions
> > > +	 * need to be atomic.
> > > +	 * This is really ugly code, we should rewrite scanning and make
> > > +	 * all this more understandable for humans.
> > > +	 */
> > 
> > So bss_info_changed() is now non-atomic as well? Because that would be
> > very useful for rt2x00. :)
> 
> Yeah, it's been for a while, in fact.

Ah ok. Well I'll create a oatch to cleanup rt2x00 then. :)

Thanks,

Ivo