Re: [PATCH] e100: Use pci_pme_active for clearing wake-up events and disabling PME#

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Frans Pop <elendil-EIBgga6/0yRmR6Xm/wNWPw@public.gmane.org>
To: "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	e1000-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	jesse.brandeburg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [PATCH] e100: Use pci_pme_active for clearing wake-up events and disabling PME#
Date: Tue, 9 Sep 2008 18:01:30 +0200	[thread overview]
Message-ID: <200809091801.31732.elendil@planet.nl> (raw)
In-Reply-To: <200809091514.23817.rjw-KKrjLPT3xs0@public.gmane.org>

On Tuesday 09 September 2008, Rafael J. Wysocki wrote:
> The appended patch should fix the problem (ISTR sending it some time
> ago already).

Patch works for me.

Thanks Rafael!

> e100: Use pci_pme_active for clearing wake-up events and disabling PME#
>
> Currently e100 uses pci_enable_wake() to clear pending wake-up events
> and disable PME# during intitialization, but that function is not
> suitable for this purpose, because it immediately returns error code
> if device_may_wakeup() returns false for given device.
>
> Make e100 use pci_pme_active(), which carries out exactly the
> required operations, instead.
>
> Signed-off-by: Rafael J. Wysocki <rjw-KKrjLPT3xs0@public.gmane.org>

Tested-by: Frans Pop <elendil-EIBgga6/0yRmR6Xm/wNWPw@public.gmane.org>

WARNING: multiple messages have this Message-ID (diff)

From: Frans Pop <elendil@planet.nl>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net,
	netdev@vger.kernel.org, kernel-testers@vger.kernel.org,
	jesse.brandeburg@intel.com,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] e100: Use pci_pme_active for clearing wake-up events and disabling PME#
Date: Tue, 9 Sep 2008 18:01:30 +0200	[thread overview]
Message-ID: <200809091801.31732.elendil@planet.nl> (raw)
In-Reply-To: <200809091514.23817.rjw@sisk.pl>

On Tuesday 09 September 2008, Rafael J. Wysocki wrote:
> The appended patch should fix the problem (ISTR sending it some time
> ago already).

Patch works for me.

Thanks Rafael!

> e100: Use pci_pme_active for clearing wake-up events and disabling PME#
>
> Currently e100 uses pci_enable_wake() to clear pending wake-up events
> and disable PME# during intitialization, but that function is not
> suitable for this purpose, because it immediately returns error code
> if device_may_wakeup() returns false for given device.
>
> Make e100 use pci_pme_active(), which carries out exactly the
> required operations, instead.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

Tested-by: Frans Pop <elendil@planet.nl>

next prev parent reply	other threads:[~2008-09-09 16:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-09  6:12 [regression] e100: PCI wake-up handling rework causes "Error clearing wake event" Frans Pop
2008-09-09 13:14 ` [PATCH] e100: Use pci_pme_active for clearing wake-up events and disabling PME# (was: Re: [regression] e100: PCI wake-up handling rework causes "Error clearing wake event") Rafael J. Wysocki
     [not found]   ` <200809091514.23817.rjw-KKrjLPT3xs0@public.gmane.org>
2008-09-09 16:01     ` Frans Pop [this message]
2008-09-09 16:01       ` [PATCH] e100: Use pci_pme_active for clearing wake-up events and disabling PME# Frans Pop
2008-09-10 22:31   ` [PATCH] e100: Use pci_pme_active for clearing wake-up events and disabling PME# (was: Re: [regression] e100: PCI wake-up handling rework causes "Error clearing wake event") Andrew Morton
2008-09-10 22:31     ` Andrew Morton
     [not found]     ` <20080910153124.8536a7db.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-09-10 23:07       ` Rafael J. Wysocki
2008-09-10 23:07         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200809091801.31732.elendil@planet.nl \
    --to=elendil-eibgga6/0yrmr6xm/wnwpw@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=e1000-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=jesse.brandeburg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rjw-KKrjLPT3xs0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.