All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <paul@pwsan.com>
To: linux-omap@vger.kernel.org
Cc: Paul Walmsley <paul@pwsan.com>
Subject: [PATCH v2 12/12] OMAP2/3 clock: warn if clock is missing clockdomain
Date: Wed, 10 Sep 2008 10:48:10 -0600	[thread overview]
Message-ID: <20080910164807.17024.60748.stgit@localhost.localdomain> (raw)
In-Reply-To: <20080910164631.17024.43733.stgit@localhost.localdomain>

At this point, all OMAP2/3 clocks should be associated with a clockdomain.
Warn in clk_register() if any are missing a clockdomain

Signed-off-by: Paul Walmsley <paul@pwsan.com>
---
 arch/arm/mach-omap2/clock.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
index 88c8ef4..eee5511 100644
--- a/arch/arm/mach-omap2/clock.c
+++ b/arch/arm/mach-omap2/clock.c
@@ -78,8 +78,10 @@ void omap2_init_clk_clkdm(struct clk *clk)
 {
 	struct clockdomain *clkdm;
 
-	if (!clk->clkdm.name)
+	if (!clk->clkdm.name) {
+		pr_err("clock: %s: missing clockdomain", clk->name);
 		return;
+	}
 
 	clkdm = clkdm_lookup(clk->clkdm.name);
 	if (clkdm) {
@@ -87,8 +89,8 @@ void omap2_init_clk_clkdm(struct clk *clk)
 			 clk->name, clk->clkdm.name);
 		clk->clkdm.ptr = clkdm;
 	} else {
-		pr_debug("clock: could not associate clk %s to "
-			 "clkdm %s\n", clk->name, clk->clkdm.name);
+		pr_err("clock: %s: could not associate to clkdm %s\n",
+		       clk->name, clk->clkdm.name);
 	}
 }
 



  parent reply	other threads:[~2008-09-10 16:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-10 16:47 [PATCH v2 00/12] Update OMAP2/3 powerdomains, clockdomains Paul Walmsley
2008-09-10 16:47 ` [PATCH v2 01/12] OMAP2/3 clockdomains: add CM and PRM clkdms Paul Walmsley
2008-09-10 16:47 ` [PATCH v2 02/12] OMAP2/3 clock: convert wkup_clkdm PRM clocks to prm_clkdm Paul Walmsley
2008-09-10 16:47 ` [PATCH v2 03/12] OMAP2/3 clock: annotate PRM clocks that are missing clockdomains Paul Walmsley
2008-09-10 16:47 ` [PATCH v2 04/12] OMAP2/3 clock: convert wkup_clkdm CM clocks to cm_clkdm Paul Walmsley
2008-09-10 16:47 ` [PATCH v2 05/12] OMAP2/3 clock: mark the rest of the CM clocks as belonging " Paul Walmsley
2008-09-10 16:47 ` [PATCH v2 06/12] OMAP2/3 clockdomain: remove wkup_clkdm Paul Walmsley
2008-09-10 16:47 ` [PATCH v2 07/12] OMAP3 PRCM: add DPLL1-5 powerdomains, clockdomains Paul Walmsley
2008-09-10 16:47 ` [PATCH v2 08/12] OMAP3 clock: mark DPLL clocks with their DPLLx clockdomains Paul Walmsley
2008-09-10 16:48 ` [PATCH v2 09/12] OMAP2/3 clock: note clockdomains for remaining clocks Paul Walmsley
2008-09-10 16:48 ` [PATCH v2 10/12] OMAP2 clockdomain: add virt_opp_clkdm Paul Walmsley
2008-09-10 16:48 ` [PATCH v2 11/12] OMAP3 clock: remove duplicate call to omap2_init_clk_clkdm() Paul Walmsley
2008-09-10 16:48 ` Paul Walmsley [this message]
2008-09-12 22:33 ` [PATCH v2 00/12] Update OMAP2/3 powerdomains, clockdomains Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080910164807.17024.60748.stgit@localhost.localdomain \
    --to=paul@pwsan.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.