All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Walle <bwalle@suse.de>
To: Jay Lan <jlan@sgi.com>
Cc: kexec@lists.infradead.org, Jack Steiner <steiner@sgi.com>,
	linux-ia64@vger.kernel.org
Subject: Re: [PATCH]IA64: assign a distinguishable label to uncached memory in /proc/iomem
Date: Fri, 12 Sep 2008 09:55:48 +0200	[thread overview]
Message-ID: <20080912095548.54471a93@kepler.site> (raw)
In-Reply-To: <48C9A2F8.3060308@sgi.com>

* Jay Lan <jlan@sgi.com> [2008-09-11]: 

> -				} else {
> -					name = "System RAM";
> -				}
> +				} else if (md->attribute == EFI_MEMORY_UC)
> +						name = "Uncached RAM";
> +					else
> +						name = "System RAM";
                                ^^^^^^^^

Isn't that too much indent, i.e. shouldn't that be

--- a/arch/ia64/kernel/efi.c
+++ b/arch/ia64/kernel/efi.c
@@ -1232,9 +1232,10 @@ efi_initialize_iomem_resources(struct re
                                if (md->attribute & EFI_MEMORY_WP) {
                                        name = "System ROM";
                                        flags |= IORESOURCE_READONLY;
-                               } else {
+                               } else if (md->attribute ==
EFI_MEMORY_UC)
+                                       name = "Uncached RAM";
+                               else
                                        name = "System RAM";
-                               }
                                break;



Bernhard

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Bernhard Walle <bwalle@suse.de>
To: Jay Lan <jlan@sgi.com>
Cc: kexec@lists.infradead.org, Jack Steiner <steiner@sgi.com>,
	linux-ia64@vger.kernel.org
Subject: Re: [PATCH]IA64: assign a distinguishable label to uncached memory
Date: Fri, 12 Sep 2008 07:55:48 +0000	[thread overview]
Message-ID: <20080912095548.54471a93@kepler.site> (raw)
In-Reply-To: <48C9A2F8.3060308@sgi.com>

* Jay Lan <jlan@sgi.com> [2008-09-11]: 

> -				} else {
> -					name = "System RAM";
> -				}
> +				} else if (md->attribute = EFI_MEMORY_UC)
> +						name = "Uncached RAM";
> +					else
> +						name = "System RAM";
                                ^^^^^^^^

Isn't that too much indent, i.e. shouldn't that be

--- a/arch/ia64/kernel/efi.c
+++ b/arch/ia64/kernel/efi.c
@@ -1232,9 +1232,10 @@ efi_initialize_iomem_resources(struct re
                                if (md->attribute & EFI_MEMORY_WP) {
                                        name = "System ROM";
                                        flags |= IORESOURCE_READONLY;
-                               } else {
+                               } else if (md->attribute =
EFI_MEMORY_UC)
+                                       name = "Uncached RAM";
+                               else
                                        name = "System RAM";
-                               }
                                break;



Bernhard

  reply	other threads:[~2008-09-12  7:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-11 23:00 [PATCH]IA64: assign a distinguishable label to uncached memory in /proc/iomem Jay Lan
2008-09-11 23:00 ` [PATCH]IA64: assign a distinguishable label to uncached memory in Jay Lan
2008-09-12  7:55 ` Bernhard Walle [this message]
2008-09-12  7:55   ` [PATCH]IA64: assign a distinguishable label to uncached memory Bernhard Walle
2008-09-12  7:58   ` [PATCH]IA64: assign a distinguishable label to uncached memory in /proc/iomem Bernhard Walle
2008-09-12  7:58     ` [PATCH]IA64: assign a distinguishable label to uncached memory Bernhard Walle
2008-09-12 13:57     ` [PATCH]IA64: assign a distinguishable label to uncached memory in /proc/iomem Jay Lan
2008-09-12 13:57       ` [PATCH]IA64: assign a distinguishable label to uncached memory Jay Lan
2008-09-15  5:10 ` [PATCH]IA64: assign a distinguishable label to uncached memory in /proc/iomem Simon Horman
2008-09-15  5:10   ` [PATCH]IA64: assign a distinguishable label to uncached memory Simon Horman
2008-09-15 17:08   ` [PATCH]IA64: assign a distinguishable label to uncached memory in /proc/iomem Jay Lan
2008-09-15 17:08     ` [PATCH]IA64: assign a distinguishable label to uncached memory Jay Lan
2008-09-15 23:49     ` [PATCH]IA64: assign a distinguishable label to uncached memory in /proc/iomem Simon Horman
2008-09-15 23:49       ` [PATCH]IA64: assign a distinguishable label to uncached memory Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080912095548.54471a93@kepler.site \
    --to=bwalle@suse.de \
    --cc=jlan@sgi.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=steiner@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.