Re: [patch] kill compile warning on twl4030-power.c

[Felipe Balbi <me@felipebalbi.com>]

On Mon, Sep 15, 2008 at 08:30:20PM +0300, Peter 'p2' De Schrijver wrote:
> > > > -#if defined(CONFIG_MACH_OMAP_3430SDP) || defined(CONFIG_MACH_OMAP_3430LABRADOR)
> > > > -       /* Disabling AC charger effect on sleep-active transitions */
> > > > -       err |= twl4030_i2c_read_u8(TWL4030_MODULE_PM_MASTER, &data,
> > > > -                                       R_CFG_P1_TRANSITION);
> > > > -       data &= 0x0;
> > > 
> > > This does not make sense :) 
> > 
> > Why not? That data variable is only used on 3430SDP and LABRADOR
> > anyways. Any other build will keep generating "unused variable" warnings
> > and that's annoying :-p
> 
> Because a logical and with 0 will always result in 0. So the read is
> useless. So the original code is probably wrong.

Maybe you meant data &= ~(1 << 0);  ???

-- 
balbi