All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
Cc: linux-omap@vger.kernel.org, me@felipebalbi.com
Subject: Re: [PATCH] Fix build for beagleboard
Date: Tue, 23 Sep 2008 13:54:18 +0300	[thread overview]
Message-ID: <20080923105417.GH5102@atomide.com> (raw)
In-Reply-To: <1221568163-30976-1-git-send-email-peter.de-schrijver@nokia.com>

* Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com> [080916 15:30]:

Pushing.

Tony

> 
> Signed-off-by: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
> ---
>  drivers/i2c/chips/twl4030-power.c |   25 +++++++++++++++----------
>  1 files changed, 15 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/i2c/chips/twl4030-power.c b/drivers/i2c/chips/twl4030-power.c
> index 195c3c4..ea8f447 100644
> --- a/drivers/i2c/chips/twl4030-power.c
> +++ b/drivers/i2c/chips/twl4030-power.c
> @@ -212,7 +216,6 @@ static int __init twl4030_write_script(u8 address, struct triton_ins *script,
>  static int __init config_sleep_wake_sequence(void)
>  {
>  	int err = 0;
> -	u8 data;
>  
>  	/*
>  	 * CLKREQ is pulled high on the 2430SDP, therefore, we need to take
> @@ -242,14 +245,16 @@ static int __init config_sleep_wake_sequence(void)
>  	err |= twl4030_write_script(0x2F, sleep_off_seq,
>  					ARRAY_SIZE(sleep_off_seq));
>  
> -#if defined(CONFIG_MACH_OMAP_3430SDP) || defined(CONFIG_MACH_OMAP_3430LABRADOR)
> -	/* Disabling AC charger effect on sleep-active transitions */
> -	err |= twl4030_i2c_read_u8(TWL4030_MODULE_PM_MASTER, &data,
> -					R_CFG_P1_TRANSITION);
> -	data &= 0x0;
> -	err |= twl4030_i2c_write_u8(TWL4030_MODULE_PM_MASTER, data ,
> -					R_CFG_P1_TRANSITION);
> -#endif
> +	if (machine_is_omap_3430sdp() || machine_is_omap_ldp()) {
> +		u8 data;
> +		/* Disabling AC charger effect on sleep-active transitions */
> +		err |= twl4030_i2c_read_u8(TWL4030_MODULE_PM_MASTER, &data,
> +						R_CFG_P1_TRANSITION);
> +		data &= ~(1<<1);
> +		err |= twl4030_i2c_write_u8(TWL4030_MODULE_PM_MASTER, data ,
> +						R_CFG_P1_TRANSITION);
> +	}
> +
>  	/* P1/P2/P3 LVL_WAKEUP should be on LEVEL */
>  	err |= twl4030_i2c_write_u8(TWL4030_MODULE_PM_MASTER, LVL_WAKEUP,
>  					R_P1_SW_EVENTS);
> -- 
> 1.5.6.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2008-09-23 10:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-15 15:12 [patch] kill compile warning on twl4030-power.c Felipe Balbi
2008-09-15 15:55 ` Peter 'p2' De Schrijver
2008-09-15 16:21   ` Felipe Balbi
2008-09-15 16:23     ` Felipe Balbi
2008-09-15 16:24     ` Peter 'p2' De Schrijver
2008-09-15 16:36       ` Felipe Balbi
2008-09-15 17:30         ` Peter 'p2' De Schrijver
2008-09-15 17:34           ` Felipe Balbi
2008-09-15 18:23           ` Felipe Balbi
2008-09-16 12:29             ` [PATCH] Fix build for beagleboard Peter 'p2' De Schrijver
2008-09-23 10:54               ` Tony Lindgren [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-09-11 11:50 [PATCH] Fix for twl4030-power.c build failure " Peter 'p2' De Schrijver
2008-09-11 11:50 ` [PATCH] Fix build " Peter 'p2' De Schrijver
2008-09-11 18:15   ` Tony Lindgren
2008-09-12 10:32     ` [PATCH] *** SUBJECT HERE *** Peter 'p2' De Schrijver
2008-09-12 10:32       ` [PATCH] Fix build for beagleboard Peter 'p2' De Schrijver
2008-09-12 12:06         ` Felipe Balbi
2008-09-12 17:21           ` Tony Lindgren
2008-09-12 14:02         ` Paul Walmsley
2008-09-12 10:31   ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080923105417.GH5102@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=me@felipebalbi.com \
    --cc=peter.de-schrijver@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.