From: Paul Mundt <lethal@linux-sh.org>
To: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] mtd: sh_flctl: add support for Renesas SuperH FLCTL
Date: Wed, 17 Sep 2008 23:57:32 +0900 [thread overview]
Message-ID: <20080917145731.GA31104@linux-sh.org> (raw)
In-Reply-To: <48C62D1E.7020906@renesas.com>
On Tue, Sep 09, 2008 at 05:00:30PM +0900, Yoshihiro Shimoda wrote:
> Several Renesas SuperH CPU has FLCTL. The FLCTL support NAND Flash.
> This driver support SH7723.
>
> Signed-off-by: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>
> + flctl->reg = ioremap(res->start, res->end - res->start);
> + if (flctl->reg == NULL) {
> + printk(KERN_ERR "%s: ioremap error.\n", __func__);
> + ret = -ENOMEM;
> + goto err;
> + }
> +
You have an off-by-1 here, this wants to be res->end - res->start + 1.
Other than that, it looks ok to me at first glance.
Acked-by: Paul Mundt <lethal@linux-sh.org>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] mtd: sh_flctl: add support for Renesas SuperH FLCTL
Date: Wed, 17 Sep 2008 14:57:32 +0000 [thread overview]
Message-ID: <20080917145731.GA31104@linux-sh.org> (raw)
In-Reply-To: <48C62D1E.7020906@renesas.com>
On Tue, Sep 09, 2008 at 05:00:30PM +0900, Yoshihiro Shimoda wrote:
> Several Renesas SuperH CPU has FLCTL. The FLCTL support NAND Flash.
> This driver support SH7723.
>
> Signed-off-by: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>
> + flctl->reg = ioremap(res->start, res->end - res->start);
> + if (flctl->reg = NULL) {
> + printk(KERN_ERR "%s: ioremap error.\n", __func__);
> + ret = -ENOMEM;
> + goto err;
> + }
> +
You have an off-by-1 here, this wants to be res->end - res->start + 1.
Other than that, it looks ok to me at first glance.
Acked-by: Paul Mundt <lethal@linux-sh.org>
next prev parent reply other threads:[~2008-09-17 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 8:00 [PATCH] mtd: sh_flctl: add support for Renesas SuperH FLCTL Yoshihiro Shimoda
2008-09-09 8:00 ` Yoshihiro Shimoda
2008-09-17 14:57 ` Paul Mundt [this message]
2008-09-17 14:57 ` Paul Mundt
2008-09-18 12:25 ` Yoshihiro Shimoda
2008-09-18 12:25 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080917145731.GA31104@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=shimoda.yoshihiro@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.