All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Martin Knoblauch <knobi-Ys4E+72pFW0hFhg+JK9F0w@public.gmane.org>
Cc: Greg Banks
	<gnb-cP1dWloDopni96+mSzHFpQC/G2K4zDHf@public.gmane.org>,
	linux-nfs list <linux-nfs@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC][Resend] Make NFS-Client readahead tunable
Date: Thu, 18 Sep 2008 01:18:18 -0700	[thread overview]
Message-ID: <20080918011818.950901ff.akpm@linux-foundation.org> (raw)
In-Reply-To: <418380.19358.qm-1+WuAixcP4WvuULXzWHTWIglqE1Y4D90QQ4Iyu8u01E@public.gmane.org>

On Thu, 18 Sep 2008 00:42:58 -0700 (PDT) Martin Knoblauch <knobi-Ys4E+72pFW0hFhg+JK9F0w@public.gmane.org> wrote:

> ----- Original Message ----
> 
> > From: Andrew Morton <akpm@linux-foundation.org>
> > To: Greg Banks <gnb-cP1dWloDopni96+mSzHFpQC/G2K4zDHf@public.gmane.org>
> > Cc: Martin Knoblauch <knobi-Ys4E+72pFW0hFhg+JK9F0w@public.gmane.org>; linux-nfs list <linux-nfs@vger.kernel.org>; linux-kernel@vger.kernel.org
> > Sent: Thursday, September 18, 2008 5:13:34 AM
> > Subject: Re: [RFC][Resend] Make NFS-Client readahead tunable
> > 
> > On Thu, 18 Sep 2008 11:42:54 +1000 Greg Banks wrote:
> > 
> > > I think having a tunable for client readahead is an excellent idea,
> > > although not to solve your particular problem.  The SLES10 kernel has a
> > > patch which does precisely that, perhaps Neil could post it.
> > > 
> > > I don't think there's a lot of point having both a module parameter and
> > > a sysctl.
> > 
> > mount -o remount,readahead=42
> 
> [root@lpsdm52 ~]# mount -o remount,readahead=42 /net/spsdms/fs13
> Bad nfs mount parameter: readahead
> [root@lpsdm52 ~]# mount -o readahead=42 /net/spsdms/fs13
> Bad nfs mount parameter: readahead
> 
> 
>  I assume the reply was meant to say that the correct way of introducing a modifyable readahead size is to implement it as a mount option ? :-)

Yes.

> I considered it, but it seems to be more intrusive than the workaround patch. It also needs changes to userspace tools - correct?

No.  mount(8) will pass unrecognised options straight down into the
filesystem driver.

It's better this way - it allows the tunable to be set on a per-mount
basis rather than machine-wide.

Note that for block devices, readahead is a per-backing_dev_info thing
(and a backing_dev_info has a 1:1 relationship to a disk drive for sane
setups).  

And the NFS client maintains a backing_dev_info, which appears to map
onto a server, so making the NFS readahead a per-backing_dev_info (ie:
per server) thing might make sense.  Maybe nfs makes per-server information
manipulatable down in sysfs somewhere..


WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Martin Knoblauch <knobi@knobisoft.de>
Cc: Greg Banks <gnb@melbourne.sgi.com>,
	linux-nfs list <linux-nfs@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC][Resend] Make NFS-Client readahead tunable
Date: Thu, 18 Sep 2008 01:18:18 -0700	[thread overview]
Message-ID: <20080918011818.950901ff.akpm@linux-foundation.org> (raw)
In-Reply-To: <418380.19358.qm@web32608.mail.mud.yahoo.com>

On Thu, 18 Sep 2008 00:42:58 -0700 (PDT) Martin Knoblauch <knobi@knobisoft.de> wrote:

> ----- Original Message ----
> 
> > From: Andrew Morton <akpm@linux-foundation.org>
> > To: Greg Banks <gnb@melbourne.sgi.com>
> > Cc: Martin Knoblauch <knobi@knobisoft.de>; linux-nfs list <linux-nfs@vger.kernel.org>; linux-kernel@vger.kernel.org
> > Sent: Thursday, September 18, 2008 5:13:34 AM
> > Subject: Re: [RFC][Resend] Make NFS-Client readahead tunable
> > 
> > On Thu, 18 Sep 2008 11:42:54 +1000 Greg Banks wrote:
> > 
> > > I think having a tunable for client readahead is an excellent idea,
> > > although not to solve your particular problem.  The SLES10 kernel has a
> > > patch which does precisely that, perhaps Neil could post it.
> > > 
> > > I don't think there's a lot of point having both a module parameter and
> > > a sysctl.
> > 
> > mount -o remount,readahead=42
> 
> [root@lpsdm52 ~]# mount -o remount,readahead=42 /net/spsdms/fs13
> Bad nfs mount parameter: readahead
> [root@lpsdm52 ~]# mount -o readahead=42 /net/spsdms/fs13
> Bad nfs mount parameter: readahead
> 
> 
>  I assume the reply was meant to say that the correct way of introducing a modifyable readahead size is to implement it as a mount option ? :-)

Yes.

> I considered it, but it seems to be more intrusive than the workaround patch. It also needs changes to userspace tools - correct?

No.  mount(8) will pass unrecognised options straight down into the
filesystem driver.

It's better this way - it allows the tunable to be set on a per-mount
basis rather than machine-wide.

Note that for block devices, readahead is a per-backing_dev_info thing
(and a backing_dev_info has a 1:1 relationship to a disk drive for sane
setups).  

And the NFS client maintains a backing_dev_info, which appears to map
onto a server, so making the NFS readahead a per-backing_dev_info (ie:
per server) thing might make sense.  Maybe nfs makes per-server information
manipulatable down in sysfs somewhere..


  parent reply	other threads:[~2008-09-18  8:18 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-18  7:42 [RFC][Resend] Make NFS-Client readahead tunable Martin Knoblauch
2008-09-18  7:42 ` Martin Knoblauch
     [not found] ` <418380.19358.qm-1+WuAixcP4WvuULXzWHTWIglqE1Y4D90QQ4Iyu8u01E@public.gmane.org>
2008-09-18  8:18   ` Andrew Morton [this message]
2008-09-18  8:18     ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2008-09-21 12:53 Martin Knoblauch
2008-09-21 12:53 ` Martin Knoblauch
2008-09-21 12:50 Martin Knoblauch
2008-09-21 12:50 ` Martin Knoblauch
     [not found] ` <968192.84087.qm-f6uctMgKLEavuULXzWHTWIglqE1Y4D90QQ4Iyu8u01E@public.gmane.org>
2008-09-21 13:53   ` Chuck Lever
2008-09-21 13:53     ` Chuck Lever
2008-09-18 11:53 Martin Knoblauch
2008-09-18 11:53 ` Martin Knoblauch
     [not found] ` <688309.69831.qm-lSXk2nNw7cevuULXzWHTWIglqE1Y4D90QQ4Iyu8u01E@public.gmane.org>
2008-09-18 18:24   ` Chuck Lever
2008-09-18 18:24     ` Chuck Lever
     [not found]     ` <76bd70e30809181124t78c0d574gaed5702095c02921-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-09-18 19:03       ` Peter Staubach
2008-09-18 19:03         ` Peter Staubach
2008-09-18  9:32 Martin Knoblauch
2008-09-18  9:32 ` Martin Knoblauch
2008-09-18  8:38 Martin Knoblauch
2008-09-18  8:38 ` Martin Knoblauch
     [not found] ` <124712.40022.qm-n7KXdZBPtPqvuULXzWHTWIglqE1Y4D90QQ4Iyu8u01E@public.gmane.org>
2008-09-18  8:47   ` Andrew Morton
2008-09-18  8:47     ` Andrew Morton
2008-09-18  8:57     ` Greg Banks
2008-09-18 13:20 ` Peter Zijlstra
2008-09-18  8:19 Martin Knoblauch
2008-09-18  8:19 ` Martin Knoblauch
     [not found] ` <136998.55258.qm-RqHyxEpxwZuvuULXzWHTWIglqE1Y4D90QQ4Iyu8u01E@public.gmane.org>
2008-09-18  8:45   ` Greg Banks
2008-09-18  8:45     ` Greg Banks
2008-09-17 17:01 Martin Knoblauch
2008-09-17 17:01 ` Martin Knoblauch
2008-09-17 16:23 Martin Knoblauch
2008-09-17 16:23 ` Martin Knoblauch
     [not found] ` <804604.40886.qm-f6uctMgKLEavuULXzWHTWIglqE1Y4D90QQ4Iyu8u01E@public.gmane.org>
2008-09-17 16:43   ` Chuck Lever
2008-09-17 16:43     ` Chuck Lever
2008-09-17 16:15 Martin Knoblauch
2008-09-17 16:15 ` Martin Knoblauch
2008-09-17 16:10 Martin Knoblauch
2008-09-17 16:10 ` Martin Knoblauch
2008-09-17 16:03 Martin Knoblauch
2008-09-17 16:03 ` Martin Knoblauch
2008-09-17 13:42 Michael Trimarchi
2008-09-17 13:42 ` Michael Trimarchi
2008-09-17 13:27 Martin Knoblauch
2008-09-17 13:27 ` Martin Knoblauch
2008-09-17 13:25 Martin Knoblauch
     [not found] ` <995475.95604.qm-f6uctMgKLEavuULXzWHTWIglqE1Y4D90QQ4Iyu8u01E@public.gmane.org>
2008-09-17 15:31   ` Jim Rees
2008-09-17 13:19 Michael Trimarchi
2008-09-17 13:19 ` Michael Trimarchi
2008-09-17 13:06 Martin Knoblauch
2008-09-17 13:06 ` Martin Knoblauch
     [not found] ` <997439.5560.qm-VAEUvbQToQWvuULXzWHTWIglqE1Y4D90QQ4Iyu8u01E@public.gmane.org>
2008-09-17 13:21   ` Jim Rees
2008-09-17 14:06   ` Peter Staubach
2008-09-17 14:06     ` Peter Staubach
2008-09-17 15:41     ` Chuck Lever
2008-09-17 15:41       ` Chuck Lever
2008-09-18  1:42   ` Greg Banks
2008-09-18  1:42     ` Greg Banks
     [not found]     ` <48D1B21E.3060509-cP1dWloDopni96+mSzHFpQC/G2K4zDHf@public.gmane.org>
2008-09-18  3:13       ` Andrew Morton
2008-09-18  3:13         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080918011818.950901ff.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=gnb-cP1dWloDopni96+mSzHFpQC/G2K4zDHf@public.gmane.org \
    --cc=knobi-Ys4E+72pFW0hFhg+JK9F0w@public.gmane.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.